[SCM] Samba Shared Repository - branch v3-6-test updated

Volker Lendecke vlendec at samba.org
Sat Sep 18 08:45:13 MDT 2010

The branch, v3-6-test has been updated
       via  f5254b7 s3: Fix bug 7688, rpcclient command line completion crashing
      from  8628371 Fix array size of  a memmber of struct cli_ulogoff_state


- Log -----------------------------------------------------------------
commit f5254b772acee4b75b339a1e16812a67a17b2d1e
Author: Volker Lendecke <vl at samba.org>
Date:   Sat Sep 18 07:37:04 2010 -0700

    s3: Fix bug 7688, rpcclient command line completion crashing
    We've grown more than 100 rpcclient commands by now, so this would overwrite
    the array of 100 completions. There's nicer ways to fix this problem, but 1000
    rpcclient commands should be at least a bit away.


Summary of changes:
 source3/rpcclient/rpcclient.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c
index 4ea2b74..a0a3c42 100644
--- a/source3/rpcclient/rpcclient.c
+++ b/source3/rpcclient/rpcclient.c
@@ -54,7 +54,7 @@ handle completion of commands for readline
 static char **completion_fn(const char *text, int start, int end)
-#define MAX_COMPLETIONS 100
+#define MAX_COMPLETIONS 1000
 	char **matches;
 	int i, count=0;
 	struct cmd_list *commands = cmd_list;

Samba Shared Repository

More information about the samba-cvs mailing list