[SCM] Samba Shared Repository - branch master updated

Andrew Tridgell tridge at samba.org
Wed Sep 15 07:07:08 MDT 2010


The branch, master has been updated
       via  e7f21fa s4-rpcserver: set unbind method to NULL in remote server
      from  9a7d1b1 s3-docs: more typos in rpc_server manpage.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit e7f21fa9418aaaee81ddf16f444ba318f7c2b03e
Author: Andrew Tridgell <tridge at samba.org>
Date:   Wed Sep 15 21:50:36 2010 +1000

    s4-rpcserver: set unbind method to NULL in remote server
    
    this prevents a possible crash on disconnect

-----------------------------------------------------------------------

Summary of changes:
 source4/rpc_server/dcerpc_server.c        |    2 +-
 source4/rpc_server/remote/dcesrv_remote.c |    1 +
 2 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c
index 9103923..09b9b2a 100644
--- a/source4/rpc_server/dcerpc_server.c
+++ b/source4/rpc_server/dcerpc_server.c
@@ -554,7 +554,7 @@ static int dcesrv_connection_context_destructor(struct dcesrv_connection_context
 {
 	DLIST_REMOVE(c->conn->contexts, c);
 
-	if (c->iface) {
+	if (c->iface && c->iface->unbind) {
 		c->iface->unbind(c, c->iface);
 	}
 
diff --git a/source4/rpc_server/remote/dcesrv_remote.c b/source4/rpc_server/remote/dcesrv_remote.c
index 23c8737..bdb3693 100644
--- a/source4/rpc_server/remote/dcesrv_remote.c
+++ b/source4/rpc_server/remote/dcesrv_remote.c
@@ -322,6 +322,7 @@ static bool remote_fill_interface(struct dcesrv_interface *iface, const struct n
 	iface->syntax_id = if_tabl->syntax_id;
 	
 	iface->bind = remote_op_bind;
+	iface->unbind = NULL;
 
 	iface->ndr_pull = remote_op_ndr_pull;
 	iface->dispatch = remote_op_dispatch;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list