[SCM] Samba Shared Repository - branch master updated

Andreas Schneider asn at samba.org
Wed Sep 8 09:43:53 MDT 2010


The branch, master has been updated
       via  80eba81 s3-spoolss: Fixed a possible crash bug.
      from  77b9b97 s3: Remove a superfluous ;

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 80eba8143802dec1cad6debd85df3ab5ff47c83e
Author: Andreas Schneider <asn at samba.org>
Date:   Mon Sep 6 16:07:24 2010 +0200

    s3-spoolss: Fixed a possible crash bug.

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/srv_spoolss_util.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/srv_spoolss_util.c b/source3/rpc_server/srv_spoolss_util.c
index 5fbdc0b..927bb5e 100644
--- a/source3/rpc_server/srv_spoolss_util.c
+++ b/source3/rpc_server/srv_spoolss_util.c
@@ -2337,9 +2337,23 @@ WERROR winreg_get_printer_secdesc(TALLOC_CTX *mem_ctx,
 	goto done;
 
 create_default:
+	result = winreg_printer_openkey(tmp_ctx,
+					server_info,
+					msg_ctx,
+					&winreg_pipe,
+					path,
+					"",
+					true,
+					access_mask,
+					&hive_hnd,
+					&key_hnd);
+	if (!W_ERROR_IS_OK(result)) {
+		goto done;
+	}
+
 	result = spoolss_create_default_secdesc(tmp_ctx, &secdesc);
 	if (!W_ERROR_IS_OK(result)) {
-		return result;
+		goto done;
 	}
 
 	/* If security descriptor is owned by S-1-1-0 and winbindd is up,


-- 
Samba Shared Repository


More information about the samba-cvs mailing list