[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Thu Oct 28 01:11:09 MDT 2010


ekacnet,

like metze I would also suggest to revert this patch and simply append 
the test name to the "selftest/skip" file. Unless there is a really 
important reason I find such individual hacks inappropriate.
And if we'd once opt to reactivate this we could do it in the expected 
standard place and not changing the buildscript again.

Greets,
Matthias

Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>
>    
>> commit 04d63e973efb5b3e1bf677688f5d61ddf13cee42
>> Author: Matthieu Patou<mat at matws.net>
>> Date:   Wed Oct 27 00:50:41 2010 +0400
>>
>>      unit tests: remove smb2.dir
>>
>>      Tridge says that it's a hard to fix pb and that it's not the priority
>>      for 4.0.0
>>      
> ...
>    
>> diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
>> index 3d3ac34..5877f4f 100755
>> --- a/source4/selftest/tests.py
>> +++ b/source4/selftest/tests.py
>> @@ -314,7 +314,7 @@ plantestsuite_loadlist("samba4.ntp.signd", "dc:local", [smb4torture, 'ncacn_np:$
>>   # Tests against the NTVFS POSIX backend
>>   ntvfsargs = ["--option=torture:sharedelay=10000", "--option=torture:oplocktimeout=3", "--option=torture:writetimeupdatedelay=50000"]
>>
>> -smb2 = smb4torture_testsuites("SMB2-")
>> +smb2 = filter(lambda x: "SMB2-DIR" not in x, smb4torture_testsuites("SMB2-"))
>>      
> Shouldn't this be done, but just adding the test to the skip file?
>
> metze
>
>    



More information about the samba-cvs mailing list