[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Oct 7 05:58:55 MDT 2010


On Thu, Oct 07, 2010 at 12:40:39PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Volker,
> 
> > - Log -----------------------------------------------------------------
> > commit 342c79e26544ee5345a9d54f68f774d7ce07e530
> > Author: Volker Lendecke <vl at samba.org>
> > Date:   Wed Oct 6 15:05:59 2010 +0200
> > 
> >     s3: Make the write end of the echo responder pipe non-blocking
> >     
> >     Without this, we can get a writable pipe end, but the writev call on the pipe
> >     will block.
> 
> Don't we need to add some EAGAIN logic to writev_handler() ?
> Currently it only handles EINTR.

Well, in my tests when the pipe was writable according to
select with this patch it only wrote part of the buffer and
turned to be not writable until next time. I did not get a
EAGAIN, but maybe I did not look hard enough?

Volker


More information about the samba-cvs mailing list