[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Mon Oct 4 03:43:48 MDT 2010


The branch, master has been updated
       via  515c8f0 s3: Fix a pointer error
      from  b958f98 s3: Attempt to get the Tru64 build a bit further

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 515c8f0289f9ac0d418399499da309f3f88b1540
Author: Volker Lendecke <vl at samba.org>
Date:   Mon Oct 4 11:39:51 2010 +0200

    s3: Fix a pointer error
    
    It is not universally guaranteed that an enum is represented as a uint32_t.
    
    This starts to be THE BUG (tm) in Samba. What can I do to explain this
    to people a bit better? It seems that the verbose explanations I put into
    the recent checkins fixing similar bugs are not clear enough.
    
    Anybody who does is not 100% clear about what this patch fixes please
    contact me directly so that we can talk it through on the phone to agree
    on a wording that everybody can understand.
    
    Thanks,
    
    Volker

-----------------------------------------------------------------------

Summary of changes:
 source3/printing/nt_printing.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/printing/nt_printing.c b/source3/printing/nt_printing.c
index 59af598..1080404 100644
--- a/source3/printing/nt_printing.c
+++ b/source3/printing/nt_printing.c
@@ -751,7 +751,7 @@ static WERROR clean_up_driver_struct_level(TALLOC_CTX *mem_ctx,
 					   const char **config_file,
 					   const char **help_file,
 					   struct spoolss_StringArray *dependent_files,
-					   uint32_t *version)
+					   enum spoolss_DriverOSVersion *version)
 {
 	const char *short_architecture;
 	int i;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list