[SCM] build.samba.org - branch master updated

[Jelmer Vernooij]

The branch, master has been updated
       via  24a4baa Rename old_revs -> old_builds.
      from  accab7e Sort recent builds by age by default.

http://gitweb.samba.org/?p=build-farm.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 24a4baad73e2292c600e82906816a7631c134a70
Author: Jelmer Vernooij <jelmer at samba.org>
Date:   Sun Nov 21 20:06:02 2010 +0100

    Rename old_revs -> old_builds.

-----------------------------------------------------------------------

Summary of changes:
 buildfarm/data.py            |    2 +-
 buildfarm/sqldb.py           |    2 +-
 buildfarm/tests/test_data.py |    8 ++++----
 buildfarm/web/__init__.py    |    6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)


Changeset truncated at 500 lines:

diff --git a/buildfarm/data.py b/buildfarm/data.py
index 906eebe..ed4a7cd 100644
--- a/buildfarm/data.py
+++ b/buildfarm/data.py
@@ -411,7 +411,7 @@ class BuildResultStore(object):
                 continue
             yield self.get_build(tree, host, compiler, rev)
 
-    def get_old_revs(self, tree, host, compiler):
+    def get_old_builds(self, tree, host, compiler):
         """get a list of old builds and their status."""
         ret = []
         for build in self.get_all_builds():
diff --git a/buildfarm/sqldb.py b/buildfarm/sqldb.py
index add3500..807d50f 100644
--- a/buildfarm/sqldb.py
+++ b/buildfarm/sqldb.py
@@ -216,7 +216,7 @@ class StormCachingBuildResultStore(BuildResultStore):
         self.store.add(new_build)
         return new_build
 
-    def get_old_revs(self, tree, host, compiler):
+    def get_old_builds(self, tree, host, compiler):
         result = self.store.find(StormBuild,
             StormBuild.tree == tree,
             StormBuild.host == host,
diff --git a/buildfarm/tests/test_data.py b/buildfarm/tests/test_data.py
index 4fdd149..9388f6e 100755
--- a/buildfarm/tests/test_data.py
+++ b/buildfarm/tests/test_data.py
@@ -131,11 +131,11 @@ BUILD COMMIT REVISION: myrev
     def test_get_latest_revision_none(self):
         self.assertRaises(data.NoSuchBuildError, self.x.get_latest_revision, "tdb", "charis", "cc")
 
-    def test_get_old_revs_none(self):
+    def test_get_old_builds_none(self):
         self.assertEquals([],
-            list(self.x.get_old_revs("tdb", "charis", "gcc")))
+            list(self.x.get_old_builds("tdb", "charis", "gcc")))
 
-    def test_get_old_revs(self):
+    def test_get_old_builds(self):
         path = self.create_mock_logfile("tdb", "charis", "cc",
             contents="""
 BUILD COMMIT REVISION: 12
@@ -153,7 +153,7 @@ BUILD COMMIT REVISION: 15
 BUILD COMMIT REVISION: 15
 """)
         self.assertEquals([b1, b2],
-            list(self.x.get_old_revs("tdb", "charis", "cc")))
+            list(self.x.get_old_builds("tdb", "charis", "cc")))
 
 
 class BuildResultStoreTests(BuildFarmTestCase,BuildResultStoreTestBase):
diff --git a/buildfarm/web/__init__.py b/buildfarm/web/__init__.py
index 8e4afe5..5a481f1 100755
--- a/buildfarm/web/__init__.py
+++ b/buildfarm/web/__init__.py
@@ -432,9 +432,9 @@ class ViewBuildPage(BuildFarmPage):
 
     def show_oldrevs(self, myself, tree, host, compiler):
         """show the available old revisions, if any"""
-        old_rev_builds  = self.buildfarm.builds.get_old_revs(tree, host, compiler)
+        old_builds  = self.buildfarm.builds.get_old_builds(tree, host, compiler)
 
-        if not old_rev_builds:
+        if not old_builds:
             return
 
         yield "<h2>Older builds:</h2>\n"
@@ -443,7 +443,7 @@ class ViewBuildPage(BuildFarmPage):
         yield "<thead><tr><th>Revision</th><th>Status</th><th>Age</th></tr></thead>\n"
         yield "<tbody>\n"
 
-        for build in old_rev_builds:
+        for build in old_builds:
             yield "<tr><td>%s</td><td>%s</td><td>%s</td></tr>\n" % (
                 revision_link(myself, build.revision, tree),
                 build_status_html(myself, build), util.dhm_time(build.age))


-- 
build.samba.org