[SCM] Samba Shared Repository - branch master updated

Simo Sorce idra at samba.org
Thu Nov 18 07:03:01 MST 2010


The branch, master has been updated
       via  0b3180b ldb: error out when modules are not found
      from  47784a1 s4-tests: Descriptor tests should use the existing samdb domain_dn method instead of defining a new one

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 0b3180bbf5933943cf0c5b0e9d47da33cf4ff99c
Author: Simo Sorce <idra at samba.org>
Date:   Thu Nov 18 08:01:15 2010 -0500

    ldb: error out when modules are not found
    
    We shouldn't proceed without all required modules, it could cause damage to the
    ldb if operations are performed w/o the needed modules.
    
    Autobuild-User: Simo Sorce <idra at samba.org>
    Autobuild-Date: Thu Nov 18 14:02:34 UTC 2010 on sn-devel-104

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/ldb/common/ldb_modules.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/common/ldb_modules.c b/source4/lib/ldb/common/ldb_modules.c
index 123d218..e330137 100644
--- a/source4/lib/ldb/common/ldb_modules.c
+++ b/source4/lib/ldb/common/ldb_modules.c
@@ -312,7 +312,7 @@ int ldb_module_load_list(struct ldb_context *ldb, const char **module_list,
 		if (ops == NULL) {
 			ldb_debug(ldb, LDB_DEBUG_FATAL, "WARNING: Module [%s] not found - do you need to set LDB_MODULES_PATH?",
 				  module_list[i]);
-			continue;
+			return LDB_ERR_OPERATIONS_ERROR;
 		}
 
 		current = talloc_zero(ldb, struct ldb_module);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list