[SCM] Samba Shared Repository - branch master updated

Michael Adam obnox at samba.org
Mon May 17 03:46:15 MDT 2010


The branch, master has been updated
       via  a15b666... s3:winbind:idmap_tdb: don't check ranges when an invalid entry was found.
      from  765e9c7... wbinfo: Add better libwbclient error reporting

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a15b6664389b05ea0cded46de3abe53034a7edef
Author: Michael Adam <obnox at samba.org>
Date:   Mon May 17 10:39:00 2010 +0200

    s3:winbind:idmap_tdb: don't check ranges when an invalid entry was found.
    
    There is no point in checking the ranges this if the record found had an
    invalid/unknown type: the mapping is not filled in. If it were initialized
    to some defaults before, the check just might replace the status
    NT_STATUS_INTERNAL_DB_ERROR with a NT_STATUS_NONE_MAPPED, which is not
    as precise.

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/idmap_tdb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/idmap_tdb.c b/source3/winbindd/idmap_tdb.c
index 8bfe751..45266ab 100644
--- a/source3/winbindd/idmap_tdb.c
+++ b/source3/winbindd/idmap_tdb.c
@@ -792,6 +792,7 @@ static NTSTATUS idmap_tdb_sid_to_id(struct idmap_tdb_context *ctx, struct id_map
 	} else { /* Unknown record type ! */
 		DEBUG(2, ("Found INVALID record %s -> %s\n", keystr, (const char *)data.dptr));
 		ret = NT_STATUS_INTERNAL_DB_ERROR;
+		goto done;
 	}
 
 	/* apply filters before returning result */


-- 
Samba Shared Repository


More information about the samba-cvs mailing list