[SCM] Samba Shared Repository - branch master updated

Günther Deschner gd at samba.org
Tue May 11 16:18:06 MDT 2010


The branch, master has been updated
       via  84ab762... s4-smbtorture: getting serious about checking rap status return codes.
      from  19d99a6... s4-smbtorture: add torture_create_testuser_max_pwlen() that allows to set maxpwlen.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 84ab762fd55c1f02ec0e810813b51a0cae32b62b
Author: Günther Deschner <gd at samba.org>
Date:   Sun May 9 01:08:11 2010 +0200

    s4-smbtorture: getting serious about checking rap status return codes.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source4/torture/rap/printing.c |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/torture/rap/printing.c b/source4/torture/rap/printing.c
index e18378d..a8a3036 100644
--- a/source4/torture/rap/printing.c
+++ b/source4/torture/rap/printing.c
@@ -89,6 +89,8 @@ static bool test_netprintqenum(struct torture_context *tctx,
 		torture_assert_ntstatus_ok(tctx,
 			smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 			"smbcli_rap_netprintqenum failed");
+		torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+			"failed to enum printq");
 
 		for (q=0; q<r.out.count; q++) {
 			switch (r.in.level) {
@@ -116,6 +118,8 @@ static bool test_netprintqgetinfo(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r_enum),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r_enum.out.status),
+		"failed to enum printq");
 
 	for (p=0; p < r_enum.out.count; p++) {
 
@@ -225,6 +229,8 @@ static bool test_netprintq_pause(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqueuepause(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"smbcli_rap_netprintqueuepause failed");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"smbcli_rap_netprintqueuepause failed");
 
 	return true;
 }
@@ -242,6 +248,8 @@ static bool test_netprintq_resume(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqueueresume(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"smbcli_rap_netprintqueueresume failed");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"smbcli_rap_netprintqueueresume failed");
 
 	return true;
 }
@@ -258,6 +266,8 @@ static bool test_netprintq(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"failed to enum printq");
 
 	for (i=0; i < r.out.count; i++) {
 
@@ -447,6 +457,8 @@ static bool test_netprintjobenum(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"failed to enum printq");
 
 	for (i=0; i < r.out.count; i++) {
 
@@ -472,6 +484,8 @@ static bool test_netprintjobgetinfo(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"failed to enum printq");
 
 	for (i=0; i < r.out.count; i++) {
 
@@ -497,6 +511,8 @@ static bool test_netprintjobsetinfo(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"failed to enum printq");
 
 	for (i=0; i < r.out.count; i++) {
 
@@ -598,6 +614,8 @@ static bool test_rap_print(struct torture_context *tctx,
 	torture_assert_ntstatus_ok(tctx,
 		smbcli_rap_netprintqenum(cli->tree, lp_iconv_convenience(tctx->lp_ctx), tctx, &r),
 		"failed to enum printq");
+	torture_assert_werr_ok(tctx, W_ERROR(r.out.status),
+		"failed to enum printq");
 
 	for (i=0; i < r.out.count; i++) {
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list