[SCM] Samba Shared Repository - branch v3-4-test updated
Karolin Seeger
kseeger at samba.org
Tue May 11 06:50:19 MDT 2010
The branch, v3-4-test has been updated
via df75d92... s3-spoolss: Fix _spoolss_EnumPrinters servername handling.
via bd76c22... s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!
from fb4d896... s3-net: Fix Bug #7417. 'net rpc user password' can set the wrong password.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test
- Log -----------------------------------------------------------------
commit df75d920edaad2ef113fe6c46b3e9b36fa0930a8
Author: Günther Deschner <gd at samba.org>
Date: Thu Feb 18 12:40:00 2010 +0100
s3-spoolss: Fix _spoolss_EnumPrinters servername handling.
Guenther
(cherry picked from commit b3c2b2260a503079b9abf22f6b35b56c61c2b372)
The last two patches address bug #7418 ("net rpc printer list" command is
inoperative).
(cherry picked from commit df5f448fe371a1227a507cedc2642fa1a4b77e65)
commit bd76c22f4c7ab39b79f5cf381d39bff1b974363f
Author: Günther Deschner <gd at samba.org>
Date: Thu Feb 18 02:03:53 2010 +0100
s3-spoolss: in spoolss_EnumPrinters r->in.server is a *unique* pointer!
Guenther
(cherry picked from commit 8ce66fba03f782c0b9948a9835bb488cfa74acf9)
(cherry picked from commit cb6fcb9b16b36fcdc68bef382dbd7ecf89521d4e)
-----------------------------------------------------------------------
Summary of changes:
source3/rpc_server/srv_spoolss_nt.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
index b134386..ea81fae 100644
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -4460,7 +4460,7 @@ static WERROR enumprinters_level5(TALLOC_CTX *mem_ctx,
WERROR _spoolss_EnumPrinters(pipes_struct *p,
struct spoolss_EnumPrinters *r)
{
- const char *name;
+ const char *name = NULL;
WERROR result;
/* that's an [in out] buffer */
@@ -4488,8 +4488,10 @@ WERROR _spoolss_EnumPrinters(pipes_struct *p,
* Level 5: same as Level 2
*/
- name = talloc_strdup_upper(p->mem_ctx, r->in.server);
- W_ERROR_HAVE_NO_MEMORY(name);
+ if (r->in.server) {
+ name = talloc_strdup_upper(p->mem_ctx, r->in.server);
+ W_ERROR_HAVE_NO_MEMORY(name);
+ }
switch (r->in.level) {
case 0:
--
Samba Shared Repository
More information about the samba-cvs
mailing list