[SCM] Samba Shared Repository - branch master updated

[Volker Lendecke]

The branch, master has been updated
       via  a7b06f4... s3: Fix a memleak in check_pac_checksum
      from  6eb839c... s4-script: added a --waf option to minimal_includes.pl

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a7b06f4c0d62b570e77360e7e29b805410379b78
Author: Volker Lendecke <vl at samba.org>
Date:   Tue May 4 13:54:51 2010 +0200

    s3: Fix a memleak in check_pac_checksum

-----------------------------------------------------------------------

Summary of changes:
 source3/libads/authdata.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/libads/authdata.c b/source3/libads/authdata.c
index ed158ee..ee2dbde 100644
--- a/source3/libads/authdata.c
+++ b/source3/libads/authdata.c
@@ -100,6 +100,8 @@ static krb5_error_code check_pac_checksum(TALLOC_CTX *mem_ctx,
 	DATA_BLOB *srv_sig_blob = NULL;
 	DATA_BLOB *kdc_sig_blob = NULL;
 
+	bool bool_ret;
+
 	*pac_data_out = NULL;
 
 	pac_data = TALLOC_ZERO_P(mem_ctx, struct PAC_DATA);
@@ -292,10 +294,14 @@ static krb5_error_code check_pac_checksum(TALLOC_CTX *mem_ctx,
 		return NT_STATUS_INVALID_PARAMETER;
 	}
 
-	if (!smb_krb5_principal_compare_any_realm(context, client_principal, client_principal_pac)) {
+	bool_ret = smb_krb5_principal_compare_any_realm(
+		context, client_principal, client_principal_pac);
+
+	krb5_free_principal(context, client_principal_pac);
+
+	if (!bool_ret) {
 		DEBUG(2, ("Name in PAC [%s] does not match principal name in ticket\n",
 			  logon_name->account_name));
-		krb5_free_principal(context, client_principal_pac);
 		return NT_STATUS_ACCESS_DENIED;
 	}
 


-- 
Samba Shared Repository