[SCM] Samba Shared Repository - branch v3-4-test updated

[Karolin Seeger]

The branch, v3-4-test has been updated
       via  fcb4c51... Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
      from  36ecc6b... s3 ntlm_auth: Don't malloc data that will be talloc_free()d

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test


- Log -----------------------------------------------------------------
commit fcb4c51e79f648ae02f77784d46bcc9c7331d3cb
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Mar 25 17:09:23 2010 -0700

    Fix bug 7297 - smbd crashes with CUPS printers and no [printers] share defined.
    
    Ensure we don't dereference an array with an index of -1.
    
    Jeremy.
    (cherry picked from commit e4127ab299e654777c43d983b2e0a158baa7d79a)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/service.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/service.c b/source3/smbd/service.c
index 8490f17..88a5f3c 100644
--- a/source3/smbd/service.c
+++ b/source3/smbd/service.c
@@ -338,7 +338,7 @@ int find_service(fstring service)
 		if ((iPrinterService = lp_servicenumber(PRINTERS_NAME)) < 0) {
 			iPrinterService = load_registry_service(PRINTERS_NAME);
 		}
-		if (iPrinterService) {
+		if (iPrinterService >= 0) {
 			DEBUG(3,("checking whether %s is a valid printer name...\n", service));
 			if (pcap_printername_ok(service)) {
 				DEBUG(3,("%s is a valid printer name\n", service));


-- 
Samba Shared Repository