[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Mon Mar 22 07:02:34 MDT 2010


The branch, master has been updated
       via  dd11180... s4:registry - "RPC backend" - use "talloc_steal" and not "talloc_reference"
      from  43bb87f... s4:registry - "patchfile" - check if strings could be allocated

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit dd111804f6b22e36fe9753c6f805f0f7ae43af15
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date:   Mon Mar 22 14:00:02 2010 +0100

    s4:registry - "RPC backend" - use "talloc_steal" and not "talloc_reference"
    
    No need to create additional references but we need to assign the strings to the
    right context.

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/registry/rpc.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/registry/rpc.c b/source4/lib/registry/rpc.c
index f3be79b..ada9a55 100644
--- a/source4/lib/registry/rpc.c
+++ b/source4/lib/registry/rpc.c
@@ -229,7 +229,7 @@ static WERROR rpc_get_value_by_index(TALLOC_CTX *mem_ctx,
 		return ntstatus_to_werror(status);
 	}
 
-	*value_name = talloc_reference(mem_ctx, r.out.name->name);
+	*value_name = talloc_steal(mem_ctx, r.out.name->name);
 	*type = *(r.out.type);
 	*data = data_blob_talloc(mem_ctx, r.out.value, *r.out.length);
 
@@ -319,9 +319,9 @@ static WERROR rpc_get_subkey_by_index(TALLOC_CTX *mem_ctx,
 	}
 
 	if (name != NULL)
-		*name = talloc_reference(mem_ctx, r.out.name->name);
+		*name = talloc_steal(mem_ctx, r.out.name->name);
 	if (keyclass != NULL)
-		*keyclass = talloc_reference(mem_ctx, r.out.keyclass->name);
+		*keyclass = talloc_steal(mem_ctx, r.out.keyclass->name);
 	if (last_changed_time != NULL)
 		*last_changed_time = *(r.out.last_changed_time);
 
@@ -394,7 +394,7 @@ static WERROR rpc_query_key(TALLOC_CTX *mem_ctx, const struct registry_key *k)
 		return ntstatus_to_werror(status);
 	}
 
-	mykeydata->classname = talloc_reference(mem_ctx, r.out.classname->name);
+	mykeydata->classname = talloc_steal(mem_ctx, r.out.classname->name);
 
 	return r.out.result;
 }


-- 
Samba Shared Repository


More information about the samba-cvs mailing list