[SCM] Samba Shared Repository - branch v3-5-test updated

Karolin Seeger kseeger at samba.org
Tue Mar 16 02:00:07 MDT 2010


The branch, v3-5-test has been updated
       via  9280051... s3: Fix an uninitialized variable read
      from  6bda490... s3:smbd: make sure we always have a valid talloc stackframe

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit 9280051bfba337458722fb157f3082f93cbd9f2b
Author: Volker Lendecke <vl at samba.org>
Date:   Sun Mar 14 21:18:34 2010 +0100

    s3: Fix an uninitialized variable read
    
    Found by Laurent Gaffie <laurent.gaffie at gmail.com>
    
    Thanks for that,
    
    Volker
    
    Fix bug #7254 (An uninitialized variable read could cause an smbd crash).

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/sesssetup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/sesssetup.c b/source3/smbd/sesssetup.c
index 1529166..68cb8d3 100644
--- a/source3/smbd/sesssetup.c
+++ b/source3/smbd/sesssetup.c
@@ -1213,7 +1213,7 @@ static void reply_sesssetup_and_X_spnego(struct smb_request *req)
 	file_save("negotiate.dat", blob1.data, blob1.length);
 #endif
 
-	p2 = (char *)req->buf + data_blob_len;
+	p2 = (char *)req->buf + blob1.length;
 
 	p2 += srvstr_pull_req_talloc(talloc_tos(), req, &tmp, p2,
 				     STR_TERMINATE);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list