[SCM] Samba Shared Repository - branch master updated
Matthias Dieter Wallnöfer
mdw at samba.org
Tue Mar 2 10:04:27 MST 2010
The branch, master has been updated
via e50c982... LDB:NSS - make LDB "signed-safe" on counter variables
from 5c73ecd... s4:echo RPC - make this one "signed-safe"
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit e50c9826794f4a80b7200712afacb0752ccf8d6f
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date: Fri Nov 6 18:35:17 2009 +0100
LDB:NSS - make LDB "signed-safe" on counter variables
"i" needs to be unsigned on both places since it counts till a "count" variable
of a "struct ldb_result" object which itself is unsigned.
I see counting variables much better as "unsigned" since in most cases we don't
use negative values at all. We've only to be careful on binary searches and
downto counts regarding them.
-----------------------------------------------------------------------
Summary of changes:
source4/lib/ldb/nssldb/ldb-nss.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/lib/ldb/nssldb/ldb-nss.c b/source4/lib/ldb/nssldb/ldb-nss.c
index 8f73210..92b0635 100644
--- a/source4/lib/ldb/nssldb/ldb-nss.c
+++ b/source4/lib/ldb/nssldb/ldb-nss.c
@@ -191,7 +191,7 @@ NSS_STATUS _ldb_nss_fill_group(struct group *result,
size_t len;
size_t bufpos;
size_t lsize;
- int i;
+ unsigned int i;
bufpos = 0;
@@ -280,7 +280,7 @@ NSS_STATUS _ldb_nss_fill_initgr(gid_t group,
struct ldb_result *grlist)
{
NSS_STATUS ret;
- int i;
+ unsigned int i;
for (i = 0; i < grlist->count; i++) {
--
Samba Shared Repository
More information about the samba-cvs
mailing list