[SCM] Samba Shared Repository - branch master updated

[Stefan Metzmacher]

The branch, master has been updated
       via  232197e... s4:dsdb/common: fix major bug in lsa_BinaryString to ldb_val conversation.
      from  ca9bc96... s4:ldb_msg: first try to decode integers as signed and then fallback to unsigned

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 232197e9ab20b68a848fd798c1e8be22a72c6bb5
Author: Stefan Metzmacher <metze at samba.org>
Date:   Tue Jan 12 09:59:26 2010 +0100

    s4:dsdb/common: fix major bug in lsa_BinaryString to ldb_val conversation.
    
    In lsa_BinaryString length and size are byte counts!
    
    TODO: we may need to do byte order conversion in this functions too...
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source4/dsdb/common/util.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/dsdb/common/util.c b/source4/dsdb/common/util.c
index 7d3f460..652f134 100644
--- a/source4/dsdb/common/util.c
+++ b/source4/dsdb/common/util.c
@@ -686,7 +686,7 @@ struct lsa_BinaryString samdb_result_parameters(TALLOC_CTX *mem_ctx,
 	if (!s.array) {
 		return s;
 	}
-	s.length = s.size = val->length/2;
+	s.length = s.size = val->length;
 	memcpy(s.array, val->data, val->length);
 
 	return s;
@@ -935,7 +935,7 @@ int samdb_msg_add_parameters(struct ldb_context *sam_ldb, TALLOC_CTX *mem_ctx, s
 			     const char *attr_name, struct lsa_BinaryString *parameters)
 {
 	struct ldb_val val;
-	val.length = parameters->length * 2;
+	val.length = parameters->length;
 	val.data = (uint8_t *)parameters->array;
 	return ldb_msg_add_value(msg, attr_name, &val, NULL);
 }


-- 
Samba Shared Repository