[SCM] Samba Shared Repository - branch master updated

[Michael Adam]

The branch, master has been updated
       via  444ecac... s3:auth: add comment to nulling out stolen sampass
      from  373dcf4... s3: Remove a pointless if-statement

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 444ecac2d28e02c6cc6da8ed97010fc475e834e5
Author: Michael Adam <obnox at samba.org>
Date:   Tue Jan 12 12:25:32 2010 +0100

    s3:auth: add comment to nulling out stolen sampass
    
    Adding this comment makes me think, I could also
    have changed make_server_info_sam() talloc_move
    instead of talloc_steal, but that would have
    changed the signature... Well the comment is a
    first step. :-)
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source3/auth/auth_sam.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/auth/auth_sam.c b/source3/auth/auth_sam.c
index 834ca97..1dd8fc9 100644
--- a/source3/auth/auth_sam.c
+++ b/source3/auth/auth_sam.c
@@ -486,6 +486,10 @@ static NTSTATUS check_sam_security(const struct auth_context *auth_context,
 	become_root();
 	nt_status = make_server_info_sam(server_info, sampass);
 	unbecome_root();
+	/*
+	 * sampass has been stolen to server_info.
+	 * So NULL it out to prevent segfaults.
+	 */
 	sampass = NULL;
 
 	if (!NT_STATUS_IS_OK(nt_status)) {


-- 
Samba Shared Repository