[SCM] Samba Shared Repository - branch master updated

Volker Lendecke vlendec at samba.org
Thu Jan 7 06:57:39 MST 2010

The branch, master has been updated
       via  801edec... s3: Remove some code that has become unnecessary
      from  c1ca000... s3-docs: fix eventlogadm manpage typo.


- Log -----------------------------------------------------------------
commit 801edeccc6f529647eaed0dd23728a257cf9479f
Author: Volker Lendecke <vl at samba.org>
Date:   Thu Jan 7 14:50:43 2010 +0100

    s3: Remove some code that has become unnecessary
    The code I just removed was checked in with e5466fffc286a99f as a bug fix for
    https://bugzilla.samba.org/show_bug.cgi?id=3319. With the changes to
    is_visible_file made with 9e8b8f8c16612 these lines have become unnecessary,
    even with "hide unreadable = yes" dead msdfs symlinks show. This is because we
    can not stat(2) them and default to showing them.
    Why this change? I have a user who wants to use "hide unreadable" on msdfs
    links. Because you can't edit acls on symlinks themselves, the user created the
    targets as bogus, empty files that just exist as acl placeholders. With the
    code in place that this patch removes, we never allow this to work.
    Jeremy, please check! :-)


Summary of changes:
 source3/smbd/dir.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source3/smbd/dir.c b/source3/smbd/dir.c
index 5ce4a7b..3fe3218 100644
--- a/source3/smbd/dir.c
+++ b/source3/smbd/dir.c
@@ -1227,14 +1227,6 @@ bool is_visible_file(connection_struct *conn, const char *dir_path,
 			goto out;
-		/* If it's a dfs symlink, ignore _hide xxxx_ options */
-		if (lp_host_msdfs() &&
-				lp_msdfs_root(SNUM(conn)) &&
-				is_msdfs_link(conn, entry, NULL)) {
-			ret = true;
-			goto out;
-		}
 		/* Create an smb_filename with stream_name == NULL. */
 		status = create_synthetic_smb_fname(talloc_tos(), entry, NULL,
 						    pst, &smb_fname_base);

Samba Shared Repository

More information about the samba-cvs mailing list