[SCM] Samba Shared Repository - branch master updated

Jeremy Allison jra at samba.org
Fri Feb 26 15:55:07 MST 2010


The branch, master has been updated
       via  cfc79f2... Fix one of the valgrind warnings from bug #6814 - Fixes for problems reported by valgrind
      from  b28afd2... s4:ldb_dn: fix an uninitialized variable (found by make valgrindtest)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit cfc79f222d0fae7f976bb843da3565c58b2c375e
Author: Roel van Meer <rolek at alt001.com>
Date:   Fri Feb 26 14:54:22 2010 -0800

    Fix one of the valgrind warnings from bug #6814 - Fixes for problems reported by valgrind
    
    The timeval passed to event_add_to_select_args() must be initialized
    as event_add_to_select_args() uses a timeval_min() on this and next_event.

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/winbindd_dual.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/winbindd_dual.c b/source3/winbindd/winbindd_dual.c
index 74b2b99..26f9232 100644
--- a/source3/winbindd/winbindd_dual.c
+++ b/source3/winbindd/winbindd_dual.c
@@ -1463,6 +1463,14 @@ static bool fork_domain_child(struct winbindd_child *child)
 		FD_SET(state.sock, &r_fds);
 		maxfd = state.sock;
 
+		/*
+		 * Initialize this high as event_add_to_select_args()
+ 		 * uses a timeval_min() on this and next_event. Fix
+ 		 * from Roel van Meer <rolek at alt001.com>.
+ 		 */
+		t.tv_sec = 999999;
+		t.tv_usec = 0;
+
 		event_add_to_select_args(winbind_event_context(), &now,
 					 &r_fds, &w_fds, &t, &maxfd);
 		tp = get_timed_events_timeout(winbind_event_context(), &t);


-- 
Samba Shared Repository


More information about the samba-cvs mailing list