[SCM] Samba Shared Repository - branch master updated

Simo Sorce idra at samba.org
Wed Feb 24 09:14:50 MST 2010


The branch, master has been updated
       via  f09802c... s4:netlogon remove wrong ZERO_STRUCT of output
      from  d980268... s3: Make connections_fetch_record() static

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit f09802cfc8fae8ce06cf65372e2d4b29e962b95b
Author: Simo Sorce <idra at samba.org>
Date:   Wed Feb 24 11:02:18 2010 -0500

    s4:netlogon remove wrong ZERO_STRUCT of output
    
    This was causing marshalling faults when we returned errors.

-----------------------------------------------------------------------

Summary of changes:
 source4/rpc_server/netlogon/dcerpc_netlogon.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/rpc_server/netlogon/dcerpc_netlogon.c b/source4/rpc_server/netlogon/dcerpc_netlogon.c
index 6f58e9c..563ed5e 100644
--- a/source4/rpc_server/netlogon/dcerpc_netlogon.c
+++ b/source4/rpc_server/netlogon/dcerpc_netlogon.c
@@ -1758,8 +1758,6 @@ static WERROR dcesrv_netr_DsrEnumerateDomainTrusts(struct dcesrv_call_state *dce
 		}
 	}
 
-	ZERO_STRUCT(r->out);
-
 	trusts = talloc_zero(mem_ctx, struct netr_DomainTrustList);
 	W_ERROR_HAVE_NO_MEMORY(trusts);
 
@@ -1910,8 +1908,6 @@ static WERROR dcesrv_netr_DsRGetForestTrustInformation(struct dcesrv_call_state
 	struct ldb_context *sam_ctx;
 	WERROR werr;
 
-	ZERO_STRUCT(r->out);
-
 	if (lp_server_role(lp_ctx) != ROLE_DOMAIN_CONTROLLER) {
 		return WERR_CALL_NOT_IMPLEMENTED;
 	}
@@ -1979,8 +1975,6 @@ static NTSTATUS dcesrv_netr_GetForestTrustInformation(struct dcesrv_call_state *
 		return NT_STATUS_NOT_IMPLEMENTED;
 	}
 
-	ZERO_STRUCT(r->out);
-
 	status = dcesrv_netr_creds_server_step_check(dce_call,
 						     mem_ctx,
 						     r->in.computer_name,


-- 
Samba Shared Repository


More information about the samba-cvs mailing list