[SCM] Samba Shared Repository - branch v3-5-test updated

Karolin Seeger kseeger at samba.org
Fri Feb 19 01:18:16 MST 2010


The branch, v3-5-test has been updated
       via  fd906e7... Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
      from  b3c5b9d... s3-docs: Remove trailing whitespaces and fix a typo.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit fd906e77a0959189db767392981a89b5130939e2
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Feb 18 12:21:10 2010 -0800

    Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
    
    The charset array allocated in init_chartest() is allocated
    by MALLOC, but only some elements of it being set after allocation. Fix is to
    memset to zero after allocation.
    
    Jeremy.
    (cherry picked from commit a4e8210ba7d6d471cb9f17754244393b9c1e5930)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/mangle_hash.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/mangle_hash.c b/source3/smbd/mangle_hash.c
index 8369af4..b54dd5c 100644
--- a/source3/smbd/mangle_hash.c
+++ b/source3/smbd/mangle_hash.c
@@ -331,6 +331,7 @@ static void init_chartest( void )
 	chartest = SMB_MALLOC_ARRAY(unsigned char, 256);
 
 	SMB_ASSERT(chartest != NULL);
+	memset(chartest, '\0', 256);
 
 	for( s = (const unsigned char *)basechars; *s; s++ ) {
 		chartest[*s] |= BASECHAR_MASK;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list