[SCM] Samba Shared Repository - branch master updated
Jeremy Allison
jra at samba.org
Thu Feb 18 13:22:31 MST 2010
The branch, master has been updated
via a4e8210... Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
from df13b13... Fix bug #7154 - mangling method = hash can crash storing a name not containing a '.'
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit a4e8210ba7d6d471cb9f17754244393b9c1e5930
Author: Jeremy Allison <jra at samba.org>
Date: Thu Feb 18 12:21:10 2010 -0800
Fix bug #7155 - valgrind Conditional jump or move depends on uninitialised value(s) error when "mangling method = hash"
The charset array allocated in init_chartest() is allocated
by MALLOC, but only some elements of it being set after allocation. Fix is to
memset to zero after allocation.
Jeremy.
-----------------------------------------------------------------------
Summary of changes:
source3/smbd/mangle_hash.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/smbd/mangle_hash.c b/source3/smbd/mangle_hash.c
index 1482d10..d1af099 100644
--- a/source3/smbd/mangle_hash.c
+++ b/source3/smbd/mangle_hash.c
@@ -331,6 +331,7 @@ static void init_chartest( void )
chartest = SMB_MALLOC_ARRAY(unsigned char, 256);
SMB_ASSERT(chartest != NULL);
+ memset(chartest, '\0', 256);
for( s = (const unsigned char *)basechars; *s; s++ ) {
chartest[*s] |= BASECHAR_MASK;
--
Samba Shared Repository
More information about the samba-cvs
mailing list