[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Thu Feb 11 07:53:07 MST 2010


The branch, master has been updated
       via  14c4c2c... ldb_match - Ignore ":dn" part of extended matches for now
      from  45defdb... s4-provision: import the R2 functional level

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 14c4c2c735d6b263d167bf5255fcf60de2c91110
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date:   Thu Feb 11 15:42:48 2010 +0100

    ldb_match - Ignore ":dn" part of extended matches for now
    
    It's not fully clear what this ":dn" part means for us. What we know is that
    older AD implementations (Windows Server 2000, 2003) need it to have extended
    matches working in the expected way.
    
    To be able to interoperate with s3's winbind and other tools I and gd decided
    to transform this into a warning until we know what to do.
    
    This should fix bug #6511.

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/ldb/common/ldb_match.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/common/ldb_match.c b/source4/lib/ldb/common/ldb_match.c
index f639eff..4bd121a 100644
--- a/source4/lib/ldb/common/ldb_match.c
+++ b/source4/lib/ldb/common/ldb_match.c
@@ -316,8 +316,11 @@ static int ldb_match_extended(struct ldb_context *ldb,
 	struct ldb_message_element *el;
 
 	if (tree->u.extended.dnAttributes) {
-		ldb_debug(ldb, LDB_DEBUG_ERROR, "ldb: dnAttributes extended match not supported yet");
-		return -1;
+		/* FIXME: We really need to find out what this ":dn" part in
+		 * an extended match means and how to handle it. For now print
+		 * only a warning to have s3 winbind and other tools working
+		 * against us. - Matthias */
+		ldb_debug(ldb, LDB_DEBUG_WARNING, "ldb: dnAttributes extended match not supported yet");
 	}
 	if (tree->u.extended.rule_id == NULL) {
 		ldb_debug(ldb, LDB_DEBUG_ERROR, "ldb: no-rule extended matches not supported yet");


-- 
Samba Shared Repository


More information about the samba-cvs mailing list