[SCM] Samba Shared Repository - branch v3-5-test updated

Karolin Seeger kseeger at samba.org
Thu Feb 4 03:03:50 MST 2010


The branch, v3-5-test has been updated
       via  f68ac68... Fix bug #7084 - Create time on directories not stored properly in an EA in new create time code.
      from  abcbca1... s3: Simplify the code a bit: Catch (len==0) early

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit f68ac68676bb7d3594030ebc89f13980fced32c1
Author: Jeremy Allison <jra at samba.org>
Date:   Mon Feb 1 18:50:43 2010 -0800

    Fix bug #7084 - Create time on directories not stored properly in an EA in new create time code.
    
    Remove erroneous optimisation that caused no EA to be set
    if calculated btime matched st_ex btime, and calculated DOS
    attribute matched existing file attribute.
    
    Jeremy.
    (cherry picked from commit f3ee1516e631274531439e0ab7c384d02aff789c)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/dosmode.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/dosmode.c b/source3/smbd/dosmode.c
index aaef09b..c061b21 100644
--- a/source3/smbd/dosmode.c
+++ b/source3/smbd/dosmode.c
@@ -731,13 +731,6 @@ int file_set_dosmode(connection_struct *conn, struct smb_filename *smb_fname,
 	dosmode  &= ~FILE_ATTRIBUTE_OFFLINE;
 	old_mode &= ~FILE_ATTRIBUTE_OFFLINE;
 
-	if (old_mode == dosmode &&
-			(timespec_compare(&new_create_timespec,
-				&smb_fname->st.st_ex_btime) == 0)) {
-		smb_fname->st.st_ex_mode = unixmode;
-		return(0);
-	}
-
 	smb_fname->st.st_ex_btime = new_create_timespec;
 
 #ifdef HAVE_STAT_DOS_FLAGS


-- 
Samba Shared Repository


More information about the samba-cvs mailing list