[SCM] Samba Shared Repository - branch master updated

[Stefan Metzmacher]

The branch, master has been updated
       via  aac0c58 libcli/echo: fix off by 1 crash bug
       via  21d02c0 s4:selftest: use correct name for the test "ECHO-UDP" => "echo.udp"
       via  b6fef94 libcli/echo: lowercase testsuite names
      from  35fbc7b s4-smbtorture: Make test names lowercase and dot-separated.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit aac0c58e04ac5f379fcfb0b3912d81f64f3652d2
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sat Dec 11 11:17:17 2010 +0100

    libcli/echo: fix off by 1 crash bug
    
    metze
    
    Autobuild-User: Stefan Metzmacher <metze at samba.org>
    Autobuild-Date: Sat Dec 11 13:48:54 CET 2010 on sn-devel-104

commit 21d02c0626577c213ae8cfb6ea684351e78ad511
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sat Dec 11 11:04:29 2010 +0100

    s4:selftest: use correct name for the test "ECHO-UDP" => "echo.udp"
    
    I wonder how commit 35fbc7bbda5851f7172538f79fc79be201f1d521
    (s4-smbtorture: Make test names lowercase and dot-separated)
    ever passed make test.
    
    metze

commit b6fef94ec16e17275d48f78453b3158a87c8f605
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sat Dec 11 11:03:52 2010 +0100

    libcli/echo: lowercase testsuite names
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 libcli/echo/echo.c        |    2 +-
 libcli/echo/tests/echo.c  |    4 ++--
 source4/selftest/tests.py |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/libcli/echo/echo.c b/libcli/echo/echo.c
index 46d1e28..271f71b 100644
--- a/libcli/echo/echo.c
+++ b/libcli/echo/echo.c
@@ -172,7 +172,7 @@ static void echo_request_done(struct tevent_req *subreq)
 		return;
 	}
 
-	state->message[len] = '\0';
+	state->message[len-1] = '\0';
 	/* Once the async function has completed, set tevent_req_done() */
 	tevent_req_done(req);
 }
diff --git a/libcli/echo/tests/echo.c b/libcli/echo/tests/echo.c
index 931e8b6..77a7dfa 100644
--- a/libcli/echo/tests/echo.c
+++ b/libcli/echo/tests/echo.c
@@ -81,10 +81,10 @@ NTSTATUS torture_libcli_echo_init(void)
 {
 	struct torture_suite *suite;
 
-	suite = torture_suite_create(talloc_autofree_context(), "ECHO");
+	suite = torture_suite_create(talloc_autofree_context(), "echo");
 	NT_STATUS_HAVE_NO_MEMORY(suite);
 
-	torture_suite_add_simple_test(suite, "UDP", torture_echo_udp);
+	torture_suite_add_simple_test(suite, "udp", torture_echo_udp);
 
 	suite->description = talloc_strdup(suite, "libcli/echo interface tests");
 	torture_register_suite(suite);
diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
index c2b47c9..3eee18b 100755
--- a/source4/selftest/tests.py
+++ b/source4/selftest/tests.py
@@ -339,7 +339,7 @@ for t in smb4torture_testsuites("rap."):
 for t in base + raw:
     plantestsuite_loadlist("samba4.ntvfs.cifs.%s" % t, "dc", [valgrindify(smb4torture), '//$NETBIOSNAME/cifs', '-U$USERNAME%$PASSWORD'] + ntvfsargs + [t])
 
-plansmbtorturetestsuite('ECHO-UDP', 'dc:local', '//$SERVER/whatever')
+plansmbtorturetestsuite('echo.udp', 'dc:local', '//$SERVER/whatever')
 
 # Local tests
 for t in smb4torture_testsuites("local."):


-- 
Samba Shared Repository