[SCM] Samba Shared Repository - branch master updated
Andrew Tridgell
tridge at samba.org
Wed Dec 1 14:11:01 MST 2010
The branch, master has been updated
via f5c5fd9 s4-ldap: removed an incorrect talloc_move()
from 71e2d9e s3-waf: more krb5 configure checks.
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
- Log -----------------------------------------------------------------
commit f5c5fd9e828b3e0bf6c2cdcd448c66fa1c8d41c1
Author: Andrew Tridgell <tridge at samba.org>
Date: Wed Dec 1 23:54:38 2010 +1100
s4-ldap: removed an incorrect talloc_move()
the parent of this session_info is either the stream_connection, or
its a system_session(). In either case reparenting it on the
ldapsrv_connection doesn't achieve anything that I can see.
The move was causing a steal on reference error because the
session_info often has multiple references.
Thanks to Metze for spotting this.
Autobuild-User: Andrew Tridgell <tridge at samba.org>
Autobuild-Date: Wed Dec 1 22:10:42 CET 2010 on sn-devel-104
-----------------------------------------------------------------------
Summary of changes:
source4/ldap_server/ldap_server.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source4/ldap_server/ldap_server.c b/source4/ldap_server/ldap_server.c
index 67fe183..db775c9 100644
--- a/source4/ldap_server/ldap_server.c
+++ b/source4/ldap_server/ldap_server.c
@@ -330,7 +330,7 @@ static void ldapsrv_accept(struct stream_connection *c,
}
conn->server_credentials = server_credentials;
- conn->session_info = talloc_move(conn, &session_info);
+ conn->session_info = session_info;
if (!NT_STATUS_IS_OK(ldapsrv_backend_Init(conn))) {
ldapsrv_terminate_connection(conn, "backend Init failed");
--
Samba Shared Repository
More information about the samba-cvs
mailing list