[SCM] Samba Shared Repository - branch v3-6-test updated

Jeremy Allison jra at samba.org
Thu Aug 26 17:49:18 MDT 2010


The branch, v3-6-test has been updated
       via  f86ed5e Fix bug #7651 - mknod and mkfifo fails with "No such file or directory"
      from  289e0bc winbindd: Add the client status in the clients list output

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit f86ed5efa661734ac552556d051b82994daf9052
Author: Jeremy Allison <jra at samba.org>
Date:   Thu Aug 26 16:46:45 2010 -0700

    Fix bug #7651 - mknod and mkfifo fails with "No such file or directory"
    
    Ensure we check the correct stat struct once we've created the
    special fix. Thanks to izh1979 at gmail.com for pointing out the
    bug.
    
    Jeremy.
    (cherry picked from commit 5115f789c007a155e34505852d847b99b7f4c886)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/trans2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/trans2.c b/source3/smbd/trans2.c
index 12a27b1..d905cc0 100644
--- a/source3/smbd/trans2.c
+++ b/source3/smbd/trans2.c
@@ -6799,6 +6799,7 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 	files_struct *all_fsps = NULL;
 	bool modify_mtime = true;
 	struct file_id id;
+	struct smb_filename *smb_fname_tmp = NULL;
 	SMB_STRUCT_STAT sbuf;
 
 	ZERO_STRUCT(ft);
@@ -6851,7 +6852,6 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 	sbuf = smb_fname->st;
 
 	if (!VALID_STAT(sbuf)) {
-		struct smb_filename *smb_fname_tmp = NULL;
 		/*
 		 * The only valid use of this is to create character and block
 		 * devices, and named pipes. This is deprecated (IMHO) and 
@@ -6880,7 +6880,7 @@ static NTSTATUS smb_set_file_unix_basic(connection_struct *conn,
 		}
 
 		sbuf = smb_fname_tmp->st;
-		TALLOC_FREE(smb_fname_tmp);
+		smb_fname = smb_fname_tmp;
 
 		/* Ensure we don't try and change anything else. */
 		raw_unixmode = SMB_MODE_NO_CHANGE;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list