[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Mon Aug 23 10:17:34 MDT 2010


The branch, master has been updated
       via  2d80364... s4:getncchanges.c - fix some counter variable types
      from  481044f... replace: Fix ifndefs for formatting defines.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 2d80364f1ba33519a4b12a5d910ff58d74e6e5c2
Author: Matthias Dieter Wallnöfer <mdw at samba.org>
Date:   Mon Aug 23 07:37:36 2010 +0200

    s4:getncchanges.c - fix some counter variable types
    
    They should be "unsigned" since they count LDB objects. And also the SID array
    can be counted as "unsigned".

-----------------------------------------------------------------------

Summary of changes:
 source4/rpc_server/drsuapi/getncchanges.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/rpc_server/drsuapi/getncchanges.c b/source4/rpc_server/drsuapi/getncchanges.c
index 7eb5ee0..2625595 100644
--- a/source4/rpc_server/drsuapi/getncchanges.c
+++ b/source4/rpc_server/drsuapi/getncchanges.c
@@ -690,7 +690,7 @@ static WERROR samdb_result_sid_array_dn(struct ldb_context *sam_ctx,
 					const struct dom_sid ***sids)
 {
 	struct ldb_message_element *el;
-	int i;
+	unsigned int i;
 
 	el = ldb_msg_find_element(msg, attr);
 	if (!el) {
@@ -731,7 +731,7 @@ static WERROR samdb_result_sid_array_ndr(struct ldb_context *sam_ctx,
 					 const struct dom_sid ***sids)
 {
 	struct ldb_message_element *el;
-	int i;
+	unsigned int i;
 
 	el = ldb_msg_find_element(msg, attr);
 	if (!el) {
@@ -766,7 +766,7 @@ static WERROR samdb_result_sid_array_ndr(struct ldb_context *sam_ctx,
  */
 static bool sid_list_match(const struct dom_sid **list1, const struct dom_sid **list2)
 {
-	int i, j;
+	unsigned int i, j;
 	/* do we ever have enough SIDs here to worry about O(n^2) ? */
 	for (i=0; list1[i]; i++) {
 		for (j=0; list2[j]; j++) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list