[SCM] Samba Shared Repository - branch master updated

Günther Deschner gd at samba.org
Tue Aug 17 05:06:53 MDT 2010


The branch, master has been updated
       via  36cfadc... s3-dcerpc: fix c++ build warning.
       via  35052d7... s3-dcerpc: fix uninitialized variable in cli_get_session_key().
       via  ff17516... s3-util: remove unused variable.
      from  0a89722... s3-ads: Remove unused function and file

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 36cfadcf6a49ec208c2525f1541597b25d8b9397
Author: Günther Deschner <gd at samba.org>
Date:   Tue Aug 17 13:06:36 2010 +0200

    s3-dcerpc: fix c++ build warning.
    
    Guenther

commit 35052d71d3de5e0eb3d2dfa06bf75f7547c543f8
Author: Günther Deschner <gd at samba.org>
Date:   Tue Aug 17 13:06:13 2010 +0200

    s3-dcerpc: fix uninitialized variable in cli_get_session_key().
    
    Simo, please check.
    
    Guenther

commit ff175167321f0134f2f2e445aee1af04afe72f39
Author: Günther Deschner <gd at samba.org>
Date:   Tue Aug 17 13:03:58 2010 +0200

    s3-util: remove unused variable.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/util_sock.c            |    1 -
 source3/librpc/rpc/dcerpc_gssapi.c |    2 +-
 source3/rpc_client/cli_pipe.c      |    2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/util_sock.c b/source3/lib/util_sock.c
index bb14c5d..5a658bc 100644
--- a/source3/lib/util_sock.c
+++ b/source3/lib/util_sock.c
@@ -655,7 +655,6 @@ ssize_t write_data_iov(int fd, const struct iovec *orig_iov, int iovcnt)
 
 ssize_t write_data(int fd, const char *buffer, size_t N)
 {
-	ssize_t ret;
 	struct iovec iov;
 
 	iov.iov_base = CONST_DISCARD(void *, buffer);
diff --git a/source3/librpc/rpc/dcerpc_gssapi.c b/source3/librpc/rpc/dcerpc_gssapi.c
index 777f5f1..f121265 100644
--- a/source3/librpc/rpc/dcerpc_gssapi.c
+++ b/source3/librpc/rpc/dcerpc_gssapi.c
@@ -384,7 +384,7 @@ DATA_BLOB gse_get_session_key(TALLOC_CTX *mem_ctx,
 		    gse_sesskeytype_oid.length) != 0)) {
 		DEBUG(0, ("gss_inquire_sec_context_by_oid returned unknown "
 			  "OID for data in results:\n"));
-		dump_data(1, set->elements[1].value,
+		dump_data(1, (uint8_t *)set->elements[1].value,
 			     set->elements[1].length);
 		return data_blob_null;
 	}
diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index a8766da..daf30d7 100644
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -3395,7 +3395,7 @@ NTSTATUS cli_get_session_key(TALLOC_CTX *mem_ctx,
 {
 	struct pipe_auth_data *a = cli->auth;
 	DATA_BLOB sk = data_blob_null;
-	bool make_dup;
+	bool make_dup = false;
 
 	if (!session_key || !cli) {
 		return NT_STATUS_INVALID_PARAMETER;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list