[SCM] Samba Shared Repository - branch v3-6-test updated

Jeremy Allison jra at samba.org
Fri Aug 13 17:42:35 MDT 2010


The branch, v3-6-test has been updated
       via  22e2090... pidl: fix printing of server side ndr request debug messages
      from  267320b... s3: Reduce the load on the echo handler

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test


- Log -----------------------------------------------------------------
commit 22e2090dfc1efdaebde80b0c2b99976dfbe77fe0
Author: Michael Adam <obnox at samba.org>
Date:   Fri Aug 13 17:29:07 2010 +0200

    pidl: fix printing of server side ndr request debug messages
    
    The macros NDR_PRINT_IN_DEBUG and NDR_PRINT_OUT_DEBUG are made for
    the client side. For the server side, the NDR_SET_VALUES flag needs
    to be added for the OUT struct and not for the IN struct, otherwise,
    the OUT part can print uninitialized data and the IN part may
    recalculate string lengths illegally.
    (cherry picked from commit 045f4c96d5d9c0528661499ce0e5cc729df9713d)

-----------------------------------------------------------------------

Summary of changes:
 pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm b/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
index 1f66415..1cbf187 100644
--- a/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
+++ b/pidl/lib/Parse/Pidl/Samba3/ServerNDR.pm
@@ -171,7 +171,7 @@ sub ParseFunction($$)
 	pidl "}";
 	pidl "";
 	pidl "if (DEBUGLEVEL >= 10) {";
-	pidl "\tNDR_PRINT_IN_DEBUG($fn->{NAME}, r);";
+	pidl "\tNDR_PRINT_FUNCTION_DEBUG($fn->{NAME}, NDR_IN, r);";
 	pidl "}";
 	pidl "";
 
@@ -190,7 +190,7 @@ sub ParseFunction($$)
 	pidl "}";
 	pidl "";
 	pidl "if (DEBUGLEVEL >= 10) {";
-	pidl "\tNDR_PRINT_OUT_DEBUG($fn->{NAME}, r);";
+	pidl "\nNDR_PRINT_FUNCTION_DEBUG($fn->{NAME}, NDR_OUT | NDR_SET_VALUES, r);";
 	pidl "}";
 	pidl "";
 	pidl "push = ndr_push_init_ctx(r);";


-- 
Samba Shared Repository


More information about the samba-cvs mailing list