[SCM] Samba Shared Repository - branch v3-6-test updated
Jeremy Allison
jra at samba.org
Thu Aug 12 16:28:33 MDT 2010
The branch, v3-6-test has been updated
via 5ea7f0e... Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
from a8326c6... s3-libnet: fix bug #6364: Pull realm from supplied username on libnet join
http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-6-test
- Log -----------------------------------------------------------------
commit 5ea7f0e6805b33a4f6301e892dcbb1b5bf8fe043
Author: Jeremy Allison <jra at samba.org>
Date: Thu Aug 12 14:24:01 2010 -0700
Fix bug #7617 - smbd coredump due to uninitialized variables in the performance counter code.
In the file rpc_server.c, function _winreg_QueryValue()
uint8_t *outbuf
Should be :
uint8_t *outbuf = NULL;
As it is later freed by
if (free_buf) SAFE_FREE(outbuf);
in some cases, this frees the unintialized outbuf, which causes a coredump.
(cherry picked from commit 84fd910c347ddfad6f01edbe7f6e25546c8382ee)
-----------------------------------------------------------------------
Summary of changes:
source3/rpc_server/srv_winreg_nt.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Changeset truncated at 500 lines:
diff --git a/source3/rpc_server/srv_winreg_nt.c b/source3/rpc_server/srv_winreg_nt.c
index b4105a0..568545f 100644
--- a/source3/rpc_server/srv_winreg_nt.c
+++ b/source3/rpc_server/srv_winreg_nt.c
@@ -237,8 +237,8 @@ WERROR _winreg_QueryValue(struct pipes_struct *p,
struct registry_key *regkey = find_regkey_by_hnd( p, r->in.handle );
prs_struct prs_hkpd;
- uint8_t *outbuf;
- uint32_t outbuf_size;
+ uint8_t *outbuf = NULL;
+ uint32_t outbuf_size = 0;
bool free_buf = False;
bool free_prs = False;
--
Samba Shared Repository
More information about the samba-cvs
mailing list