[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Sun Aug 8 03:07:37 MDT 2010


The branch, master has been updated
       via  cc69512... s3:rpc_server: fix valgrind warning
       via  ac9f06c... s3:smbd: fix valgrind warning, sizeof(16) != 16...
      from  66412bf... s3:rpc_server: fix memory leaks in rpc_pipe_internal_dispatch()

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit cc6951243d5641e2185ed9dee3b6ee4de07d217b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sun Aug 8 09:23:00 2010 +0200

    s3:rpc_server: fix valgrind warning
    
    metze

commit ac9f06c9b93ada5d0e8331a122e199a8f69049a3
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sun Aug 8 09:21:57 2010 +0200

    s3:smbd: fix valgrind warning, sizeof(16) != 16...
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/srv_pipe.c |    1 +
 source3/smbd/negprot.c        |    2 +-
 2 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/srv_pipe.c b/source3/rpc_server/srv_pipe.c
index 436e5be..e704d75 100644
--- a/source3/rpc_server/srv_pipe.c
+++ b/source3/rpc_server/srv_pipe.c
@@ -527,6 +527,7 @@ static bool check_bind_req(struct pipes_struct *p,
 		return False;
 	}
 
+	context_fns->next = context_fns->prev = NULL;
 	context_fns->n_cmds = rpc_srv_get_pipe_num_cmds(abstract);
 	context_fns->cmds = rpc_srv_get_pipe_cmds(abstract);
 	context_fns->context_id = context_id;
diff --git a/source3/smbd/negprot.c b/source3/smbd/negprot.c
index 4ff4eee..e61d519 100644
--- a/source3/smbd/negprot.c
+++ b/source3/smbd/negprot.c
@@ -242,7 +242,7 @@ DATA_BLOB negprot_spnego(TALLOC_CTX *ctx, struct smbd_server_connection *sconn)
 #ifdef DEVELOPER
 	/* Fix valgrind 'uninitialized bytes' issue. */
 	slen = strlen(dos_name);
-	if (slen < sizeof(16)) {
+	if (slen < 16) {
 		memset(blob_out.data+slen, '\0', 16 - slen);
 	}
 #endif


-- 
Samba Shared Repository


More information about the samba-cvs mailing list