[SCM] Samba Shared Repository - branch master updated

Stefan Metzmacher metze at samba.org
Wed Apr 28 07:46:48 MDT 2010


The branch, master has been updated
       via  4783f84... s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done()
      from  ae1c040... s4:smb_server/smb: SMBreadX can return STATUS_BUFFER_OVERFLOW

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 4783f84264d850bbceb995a1454eb01671e0c026
Author: Stefan Metzmacher <metze at samba.org>
Date:   Wed Apr 28 14:36:10 2010 +0200

    s3:smbd: add comment about returning STATUS_BUFFER_OVERFLOW in pipe_read_andx_done()
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/pipes.c |   16 +++++++++++++++-
 1 files changed, 15 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/pipes.c b/source3/smbd/pipes.c
index 9bc3fdf..aff5f53 100644
--- a/source3/smbd/pipes.c
+++ b/source3/smbd/pipes.c
@@ -449,7 +449,21 @@ static void pipe_read_andx_done(struct tevent_req *subreq)
 	state->outbuf = NULL;
 
 	srv_set_message((char *)req->outbuf, 12, nread, False);
-  
+
+#if 0
+	/*
+	 * we should return STATUS_BUFFER_OVERFLOW if there's
+	 * out standing data.
+	 *
+	 * But we can't enable it yet, as it has bad interactions
+	 * with fixup_chain_error_packet() in chain_reply().
+	 */
+	if (is_data_outstanding) {
+		error_packet_set((char *)req->outbuf, ERRDOS, ERRmoredata,
+				 STATUS_BUFFER_OVERFLOW, __LINE__, __FILE__);
+	}
+#endif
+
 	SSVAL(req->outbuf,smb_vwv5,nread);
 	SSVAL(req->outbuf,smb_vwv6,
 	      req_wct_ofs(req)


-- 
Samba Shared Repository


More information about the samba-cvs mailing list