[SCM] Samba Shared Repository - branch master updated

Matthias Dieter Wallnöfer mdw at samba.org
Wed Apr 7 07:05:40 MDT 2010


The branch, master has been updated
       via  1ac654d... s4:WHATSNEW4.txt - further updates and corrections
       via  acfd025... s4:pyregistry.c - fix indentation
       via  fa4d91e... s4:provision - add a comment which explains why "paths.dns_keytab" is stored without path reference
      from  345fcf5... s4-smbtorture: test for invalid form flags in RPC-SPOOLSS.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 1ac654d108ebeede3ff78ddb30f19e1f4d516063
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date:   Wed Apr 7 15:02:23 2010 +0200

    s4:WHATSNEW4.txt - further updates and corrections
    
    Some are inspired by ekacnet.

commit acfd02574b1d8de11beb11609020f075083aa019
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date:   Wed Apr 7 14:33:09 2010 +0200

    s4:pyregistry.c - fix indentation

commit fa4d91e1e0cc4a5383d735089b40f28e384fbd5d
Author: Matthias Dieter Wallnöfer <mwallnoefer at yahoo.de>
Date:   Wed Apr 7 14:20:18 2010 +0200

    s4:provision - add a comment which explains why "paths.dns_keytab" is stored without path reference

-----------------------------------------------------------------------

Summary of changes:
 WHATSNEW4.txt                               |   29 +++++++++++++---------
 source4/lib/registry/pyregistry.c           |   35 ++++++++++++++-------------
 source4/scripting/python/samba/provision.py |    3 ++
 3 files changed, 38 insertions(+), 29 deletions(-)


Changeset truncated at 500 lines:

diff --git a/WHATSNEW4.txt b/WHATSNEW4.txt
index 7176abe..fe5274d 100644
--- a/WHATSNEW4.txt
+++ b/WHATSNEW4.txt
@@ -73,11 +73,16 @@ http://wiki.samba.org/index.php/Samba4_DRS_TODO_List
 
 Beside this the release includes:
 
+* a new build system based on WAF
+Andrew Tridgell (tridge) invested much time to bring this up. He achieved a
+marvellous work which brings us faster building, easier management and smaller
+binaries.
+
 * enhancements in Samba4 winbind to provide a fairly good implementation of the
 most important functions needed by "libnss_winbind" and "pam_winbind"
-The use of this two components allows a user/group mapping for Windows accounts
-on UNIX and UNIX-like systems. Therefore also these accounts can be used to
-connect to services as "ssh", "login", "Xsession" and so on.
+This two components allow a user/group mapping for Windows accounts on UNIX and
+UNIX-like systems. Therefore also these accounts can be used to connect to
+services as "ssh", "login", "Xsession" and so on.
 More informations available at http://wiki.samba.org/index.php/Samba4/Winbind
 and for winbind in general, "libnss_winbind" and "pam_winbind" in the Samba 3.X
 documentation.
@@ -87,8 +92,10 @@ These can now also be set on the command line directly on the server. See
 "net acl" for further informations.
 
 * dynamic DNS updates
-A new DNS upgrade mechanism has been introduced which works with newer bind9
-releases.
+Up-to-date DNS entries are essential for Active Directory deployments. As for
+the moment Samba4 isn't yet capable to interoperate with Microsofts AD DNS
+server (regarding RPCs, ADs zone entries...) a kind of update script has been
+developed. It also permits the update of the "grant" and "resource" lists.
 
 * registry improvements
 The registry code was reworked, improved and retested. This was achieved by the
@@ -97,10 +104,11 @@ new torture tests written by gd and some additional testing against Windows
 Also some real bugs were fixed.
 
 * new Kerberos HEIMDAL release
-Abartlet imported a new release with various bugfixes
+Andrew Bartlett (abartlet) imported a new release with various bugfixes
 
 * DCE/RPC code unification work
-Metze started his work to unify these codebases between s3 and s4
+Stefan Metzmacher (metze) started his work to unify these codebases between s3
+and s4
 
 * And much more
 We always try to fix bugs and keep improving the (source) quality of our
@@ -139,9 +147,6 @@ KNOWN ISSUES
   from Samba3 to Samba4. It's not included yet in the binary distributions
   since it's completely experimental!
 
-- ACL are not set by default on shares created by the provision.
-  Work is underway on this subject and it should be fixed soon.
-
 RUNNING Samba4
 ==============
 
@@ -153,8 +158,8 @@ DEVELOPMENT and FEEDBACK
 
 We need your help! Projects as Samba 4 live from the community feedback. If you
 provide expressive bug reports, some documentation snippets on the wiki or some
-real patches - all is appreciated if it meets our quality criterias. Here you
-can find the links:
+real code patches - all is appreciated if it meets our quality criterias. Here
+you can find further references:
 
 Bugs can be filed at https://bugzilla.samba.org/ but please be aware
 that many features are simply not expected to work at this stage.  
diff --git a/source4/lib/registry/pyregistry.c b/source4/lib/registry/pyregistry.c
index d7295b5..b043594 100644
--- a/source4/lib/registry/pyregistry.c
+++ b/source4/lib/registry/pyregistry.c
@@ -266,19 +266,21 @@ static PyObject *py_open_samba(PyObject *self, PyObject *args, PyObject *kwargs)
 	const char *kwnames[] = { "lp_ctx", "session_info", NULL };
 	struct registry_context *reg_ctx;
 	WERROR result;
-    struct loadparm_context *lp_ctx;
+	struct loadparm_context *lp_ctx;
 	PyObject *py_lp_ctx, *py_session_info, *py_credentials;
 	struct auth_session_info *session_info;
-    struct cli_credentials *credentials;
-	if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOO", discard_const_p(char *, kwnames),
-					 &py_lp_ctx, &py_session_info, &py_credentials))
+	struct cli_credentials *credentials;
+	if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OOO",
+					 discard_const_p(char *, kwnames),
+					 &py_lp_ctx, &py_session_info,
+					 &py_credentials))
 		return NULL;
 
-    lp_ctx = lp_from_py_object(py_lp_ctx);
-    if (lp_ctx == NULL) {
+	lp_ctx = lp_from_py_object(py_lp_ctx);
+	if (lp_ctx == NULL) {
 		PyErr_SetString(PyExc_TypeError, "Expected loadparm context");
 		return NULL;
-    }
+	}
 
 	credentials = cli_credentials_from_py_object(py_credentials);
 	if (credentials == NULL) {
@@ -334,23 +336,22 @@ static PyObject *py_open_ldb_file(PyObject *self, PyObject *args, PyObject *kwar
 	PyObject *py_session_info = Py_None, *py_credentials = Py_None, *py_lp_ctx = Py_None;
 	WERROR result;
 	char *location;
-    struct loadparm_context *lp_ctx;
-    struct cli_credentials *credentials;
+	struct loadparm_context *lp_ctx;
+	struct cli_credentials *credentials;
 	struct hive_key *key;
 	struct auth_session_info *session_info;
 
 	if (!PyArg_ParseTupleAndKeywords(args, kwargs, "s|OOO", 
-									 discard_const_p(char *, kwnames), 
-									 &location, 
-									 &py_session_info, &py_credentials,
-									 &py_lp_ctx))
+					 discard_const_p(char *, kwnames),
+					 &location, &py_session_info,
+					 &py_credentials, &py_lp_ctx))
 		return NULL;
 
-    lp_ctx = lp_from_py_object(py_lp_ctx);
-    if (lp_ctx == NULL) {
+	lp_ctx = lp_from_py_object(py_lp_ctx);
+	if (lp_ctx == NULL) {
 		PyErr_SetString(PyExc_TypeError, "Expected loadparm context");
 		return NULL;
-    }
+	}
 
 	credentials = cli_credentials_from_py_object(py_credentials);
 	if (credentials == NULL) {
@@ -361,7 +362,7 @@ static PyObject *py_open_ldb_file(PyObject *self, PyObject *args, PyObject *kwar
 	session_info = NULL; /* FIXME */
 
 	result = reg_open_ldb_file(NULL, location, session_info, credentials,
-							   tevent_context_init(NULL), lp_ctx, &key);
+				   tevent_context_init(NULL), lp_ctx, &key);
 	PyErr_WERROR_IS_ERR_RAISE(result);
 
 	return py_talloc_steal(&PyHiveKey, key);
diff --git a/source4/scripting/python/samba/provision.py b/source4/scripting/python/samba/provision.py
index 5ac635d..f3c5bcc 100644
--- a/source4/scripting/python/samba/provision.py
+++ b/source4/scripting/python/samba/provision.py
@@ -278,6 +278,9 @@ def provision_paths_from_lp(lp, dnsdomain):
     """
     paths = ProvisionPaths()
     paths.private_dir = lp.get("private dir")
+
+    # This is stored without path prefix for the "privateKeytab" attribute in
+    # "secrets_dns.ldif".
     paths.dns_keytab = "dns.keytab"
 
     paths.shareconf = os.path.join(paths.private_dir, "share.ldb")


-- 
Samba Shared Repository


More information about the samba-cvs mailing list