[SCM] Samba Shared Repository - branch master updated - tevent-0-9-8-713-g36e889f

[Stefan Metzmacher]

The branch, master has been updated
       via  36e889f2cf5497717bdffede0c2f82e7fee79275 (commit)
       via  68b8149d1fb26b2fe1138c99d971754b0a30378b (commit)
      from  bb8a4a9d73915bc35430904bb45318141bb21e22 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 36e889f2cf5497717bdffede0c2f82e7fee79275
Author: Stefan Metzmacher <metze at samba.org>
Date:   Fri Sep 18 01:54:22 2009 +0200

    s4:schannel: fix some compiler warnings
    
    If we only do signing we can pass down a const data buffer.
    
    metze

commit 68b8149d1fb26b2fe1138c99d971754b0a30378b
Author: Stefan Metzmacher <metze at samba.org>
Date:   Sun Sep 20 23:29:11 2009 +0200

    s3:rpc_client: don't randomly fragment rpc pdu's in developer mode
    
    This is really confusing and also breaks against windows,
    as it doesn't accept fragmented bind requests.
    
    metze

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_client/cli_pipe.c  |    4 ++--
 source4/auth/gensec/schannel.c |    6 ++++--
 2 files changed, 6 insertions(+), 4 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_client/cli_pipe.c b/source3/rpc_client/cli_pipe.c
index 5392d1f..34b8616 100644
--- a/source3/rpc_client/cli_pipe.c
+++ b/source3/rpc_client/cli_pipe.c
@@ -1296,7 +1296,7 @@ static struct tevent_req *rpc_api_pipe_send(TALLOC_CTX *mem_ctx,
 
 	max_recv_frag = cli->max_recv_frag;
 
-#ifdef DEVELOPER
+#if 0
 	max_recv_frag = RPC_HEADER_LEN + 10 + (sys_random() % 32);
 #endif
 
@@ -2005,7 +2005,7 @@ static uint32 calculate_data_len_tosend(struct rpc_pipe_client *cli,
 {
 	uint32 data_space, data_len;
 
-#ifdef DEVELOPER
+#if 0
 	if ((data_left > 0) && (sys_random() % 2)) {
 		data_left = MAX(data_left/2, 1);
 	}
diff --git a/source4/auth/gensec/schannel.c b/source4/auth/gensec/schannel.c
index 0233f5e..69c50f8 100644
--- a/source4/auth/gensec/schannel.c
+++ b/source4/auth/gensec/schannel.c
@@ -296,7 +296,8 @@ static NTSTATUS schannel_unseal_packet(struct gensec_security *gensec_security,
 				struct schannel_state);
 
 	return netsec_incoming_packet(state, mem_ctx, true,
-				      data, length, sig);
+				      discard_const_p(uint8_t, data),
+				      length, sig);
 }
 
 /*
@@ -346,7 +347,8 @@ static NTSTATUS schannel_sign_packet(struct gensec_security *gensec_security,
 				struct schannel_state);
 
 	return netsec_outgoing_packet(state, mem_ctx, false,
-				      data, length, sig);
+				      discard_const_p(uint8_t, data),
+				      length, sig);
 }
 
 static const struct gensec_security_ops gensec_schannel_security_ops = {


-- 
Samba Shared Repository