[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-985-g53ef426

Jelmer Vernooij jelmer at samba.org
Mon Sep 21 08:36:02 MDT 2009


Jelmer Vernooij wrote:
> Hi Matthias,
>
> Matthias Dieter Wallnöfer wrote:
>   
>> diff --git a/source4/scripting/python/samba/samdb.py b/source4/scripting/python/samba/samdb.py
>> index 631f31c..508449a 100644
>> --- a/source4/scripting/python/samba/samdb.py
>> +++ b/source4/scripting/python/samba/samdb.py
>> @@ -186,8 +186,7 @@ pwdLastSet: 0
>>              assert(domain_dn is not None)
>>  
>>              res = self.search(domain_dn, scope=ldb.SCOPE_SUBTREE, 
>> -                              expression=filter,
>> -                              attrs=[])
>> +                              expression=filter)
>>              assert(len(res) == 1)
>>              user_dn = res[0].dn
>>     
> Please revert this change - we weren't retrieving attributes earlier,
> but with your change we're now retrieving *all* attributes.
>   
Never mind, I see it's already been pointed out and reverted.

Cheers,

Jelmer


More information about the samba-cvs mailing list