[SCM] Samba Shared Repository - branch master updated - tevent-0-9-8-359-ga0d8698

[Günther Deschner]

The branch, master has been updated
       via  a0d8698f6547a020ee0fba59704d2ebeb8c27763 (commit)
       via  de43e39487d8724c06883827e3eb2dbe6b42fc99 (commit)
       via  828b9a48fde3839d88848d5e05e24c38ef6cfb7d (commit)
       via  537ac20a92c70a4bebcb7662c7bbcb1daf745fb7 (commit)
       via  6dab835fbb981b0bb1bac68407fd29fa3a18a53a (commit)
      from  94d83b62c943837b2b3a0ca8cc83e6d41f8e8733 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit a0d8698f6547a020ee0fba59704d2ebeb8c27763
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 16 10:27:21 2009 +0200

    s3-netapi: Fix Coverity #668: FORWARD_NULL.
    
    Guenther

commit de43e39487d8724c06883827e3eb2dbe6b42fc99
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 16 10:26:28 2009 +0200

    s3-netapi: Fix Coverity #669 FORWARD_NULL.
    
    Guenthe

commit 828b9a48fde3839d88848d5e05e24c38ef6cfb7d
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 16 10:24:55 2009 +0200

    s3-netapi: Fix Coverity #670: FORWARD_NULL.
    
    Guenther

commit 537ac20a92c70a4bebcb7662c7bbcb1daf745fb7
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 16 10:15:46 2009 +0200

    s3-eventlogadm: Fix Coverity #938: UNINIT.
    
    Guenther

commit 6dab835fbb981b0bb1bac68407fd29fa3a18a53a
Author: Günther Deschner <gd at samba.org>
Date:   Wed Sep 16 10:14:05 2009 +0200

    s3-rpcclient: Fix Coverity #935: UNINIT.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source3/lib/netapi/user.c      |    6 +++---
 source3/rpcclient/cmd_lsarpc.c |    2 +-
 source3/utils/eventlogadm.c    |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/lib/netapi/user.c b/source3/lib/netapi/user.c
index 9fa3ddd..f95750f 100644
--- a/source3/lib/netapi/user.c
+++ b/source3/lib/netapi/user.c
@@ -466,7 +466,7 @@ WERROR NetUserAdd_r(struct libnetapi_ctx *ctx,
 			       &user_handle);
 
  done:
-	if (is_valid_policy_hnd(&user_handle)) {
+	if (is_valid_policy_hnd(&user_handle) && pipe_cli) {
 		rpccli_samr_Close(pipe_cli, ctx, &user_handle);
 	}
 
@@ -1696,7 +1696,7 @@ WERROR NetUserGetInfo_r(struct libnetapi_ctx *ctx,
 	}
 
  done:
-	if (is_valid_policy_hnd(&user_handle)) {
+	if (is_valid_policy_hnd(&user_handle) && pipe_cli) {
 		rpccli_samr_Close(pipe_cli, ctx, &user_handle);
 	}
 
@@ -1864,7 +1864,7 @@ WERROR NetUserSetInfo_r(struct libnetapi_ctx *ctx,
 	werr = WERR_OK;
 
  done:
-	if (is_valid_policy_hnd(&user_handle)) {
+	if (is_valid_policy_hnd(&user_handle) && pipe_cli) {
 		rpccli_samr_Close(pipe_cli, ctx, &user_handle);
 	}
 
diff --git a/source3/rpcclient/cmd_lsarpc.c b/source3/rpcclient/cmd_lsarpc.c
index b660cfa..752881c 100644
--- a/source3/rpcclient/cmd_lsarpc.c
+++ b/source3/rpcclient/cmd_lsarpc.c
@@ -1731,7 +1731,7 @@ static NTSTATUS cmd_lsa_retrieve_private_data(struct rpc_pipe_client *cli,
 	struct lsa_String name;
 	struct lsa_DATA_BUF *val;
 	DATA_BLOB session_key;
-	DATA_BLOB blob;
+	DATA_BLOB blob = data_blob_null;
 	char *secret;
 
 	if (argc < 2) {
diff --git a/source3/utils/eventlogadm.c b/source3/utils/eventlogadm.c
index d134ea8..7fc04b0 100644
--- a/source3/utils/eventlogadm.c
+++ b/source3/utils/eventlogadm.c
@@ -91,7 +91,7 @@ static int DoWriteCommand( int argc, char **argv, bool debugflag, char *exename
 	char linein[1024];
 	bool is_eor;
 	struct eventlog_Record_tdb ee;
-	uint32_t record_number;
+	uint32_t record_number = 0;
 	TALLOC_CTX *mem_ctx = talloc_tos();
 
 	f1 = stdin;


-- 
Samba Shared Repository