[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha8-1373-gb4a4186

Volker Lendecke vlendec at samba.org
Thu Sep 3 23:57:27 MDT 2009


The branch, master has been updated
       via  b4a4186556f6d33be40ef7358bcd71c83a8092f2 (commit)
      from  360436b656fc2d939175ae740ecee98d44fadaec (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit b4a4186556f6d33be40ef7358bcd71c83a8092f2
Author: Volker Lendecke <vl at samba.org>
Date:   Fri Sep 4 07:57:19 2009 +0200

    s3:smbd: Fix Coverity ID 937, REVERSE_INULL

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/open.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 0456355..492164c 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3332,12 +3332,12 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
 
 	dir_fsp = file_fsp(req, root_dir_fid);
 
-	if (is_ntfs_stream_smb_fname(dir_fsp->fsp_name)) {
+	if (dir_fsp == NULL) {
 		status = NT_STATUS_INVALID_HANDLE;
 		goto out;
 	}
 
-	if (dir_fsp == NULL) {
+	if (is_ntfs_stream_smb_fname(dir_fsp->fsp_name)) {
 		status = NT_STATUS_INVALID_HANDLE;
 		goto out;
 	}


-- 
Samba Shared Repository


More information about the samba-cvs mailing list