[SCM] Samba Shared Repository - branch v3-5-test updated

Jeremy Allison jra at samba.org
Fri Oct 23 12:41:32 MDT 2009


The branch, v3-5-test has been updated
       via  dcdec16... util: fixed place where we could look one byte past end of string
      from  b46f0a7... s3: Fix crash in pam_winbind, another reference to freed memory.

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit dcdec1663c1bba90ebe59abed0d0f70772f0eb64
Author: Andrew Tridgell <tridge at samba.org>
Date:   Thu Oct 22 11:03:27 2009 +1100

    util: fixed place where we could look one byte past end of string
    
    We need to check the length before the value

-----------------------------------------------------------------------

Summary of changes:
 lib/util/charset/util_unistr.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/lib/util/charset/util_unistr.c b/lib/util/charset/util_unistr.c
index 024dc70..045aa4a 100644
--- a/lib/util/charset/util_unistr.c
+++ b/lib/util/charset/util_unistr.c
@@ -483,7 +483,7 @@ _PUBLIC_ char *strupper_talloc_n(TALLOC_CTX *ctx, const char *src, size_t n)
 		return NULL;
 	}
 
-	while (*src && n--) {
+	while (n-- && *src) {
 		size_t c_size;
 		codepoint_t c = next_codepoint_convenience(iconv_convenience, src, &c_size);
 		src += c_size;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list