[SCM] Samba Shared Repository - branch master updated

Günther Deschner gd at samba.org
Tue Oct 20 13:44:58 MDT 2009


The branch, master has been updated
       via  d168d7f... s3-pdb_ldap: fix crash bug in ldapsam_set_trusteddom_pw().
      from  205284c... s3:Makefile: rename LDSHFLAG variables to make meaning more obvious

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d168d7fe3c7ec4b90cd526c4ea02e972ffac7835
Author: Günther Deschner <gd at samba.org>
Date:   Tue Oct 20 18:35:16 2009 +0200

    s3-pdb_ldap: fix crash bug in ldapsam_set_trusteddom_pw().
    
    Thanks Volker for the hint.
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source3/passdb/pdb_ldap.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/passdb/pdb_ldap.c b/source3/passdb/pdb_ldap.c
index 2c8d051..c464a88 100644
--- a/source3/passdb/pdb_ldap.c
+++ b/source3/passdb/pdb_ldap.c
@@ -6013,8 +6013,6 @@ static bool ldapsam_set_trusteddom_pw(struct pdb_methods *methods,
 	smbldap_make_mod(priv2ld(ldap_state), entry, &mods,
 			 "sambaClearTextPassword", pwd);
 
-	talloc_autofree_ldapmod(talloc_tos(), mods);
-
 	if (entry != NULL) {
 		prev_pwd = smbldap_talloc_single_attribute(priv2ld(ldap_state),
 				entry, "sambaClearTextPassword", talloc_tos());
@@ -6025,6 +6023,8 @@ static bool ldapsam_set_trusteddom_pw(struct pdb_methods *methods,
 		}
 	}
 
+	talloc_autofree_ldapmod(talloc_tos(), mods);
+
 	trusted_dn = trusteddom_dn(ldap_state, domain);
 	if (trusted_dn == NULL) {
 		return False;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list