root_fid changes...

Stefan (metze) Metzmacher metze at samba.org
Thu Oct 15 14:23:25 MDT 2009


Hi Tridge,

> diff --git a/source4/smb_server/smb/nttrans.c b/source4/smb_server/smb/nttrans.c
> index 23eb04b..316305a 100644
> --- a/source4/smb_server/smb/nttrans.c
> +++ b/source4/smb_server/smb/nttrans.c
> @@ -119,7 +119,8 @@ static NTSTATUS nttrans_create(struct smbsrv_request *req,
>  	params = trans->in.params.data;
>  
>  	io->ntcreatex.in.flags            = IVAL(params,  0);
> -	io->ntcreatex.in.root_fid.ntvfs   = smbsrv_pull_fnum(req, req->in.vwv, 4);
> +	io->ntcreatex.in.root_fid.fnum    = IVAL(params,  4);
> +	io->ntcreatex.in.root_fid.ntvfs   = smbsrv_pull_fnum(req, params, 4);

root_fid is a union, you can't set two union arms at the same time.

It's really confusing to read this code...

metze


More information about the samba-cvs mailing list