[SCM] Samba Shared Repository - branch master updated

Andrew Tridgell tridge at samba.org
Mon Nov 30 00:15:42 MST 2009


The branch, master has been updated
       via  8331b4c... s4-ldb: check for -ve value for page size
      from  a5e0f43... s4-dsdb: don't call ldb_next_init() twice in objectclass module

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 8331b4c4f8ff1cab6fef2e402a3fda3a95ea091d
Author: Andrew Tridgell <tridge at samba.org>
Date:   Mon Nov 30 17:47:56 2009 +1100

    s4-ldb: check for -ve value for page size
    
    This comes from a tip from Howard Chu. Apparently some clients
    will send a -ve page size value.

-----------------------------------------------------------------------

Summary of changes:
 source4/lib/ldb/modules/paged_results.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source4/lib/ldb/modules/paged_results.c b/source4/lib/ldb/modules/paged_results.c
index 774109f..ff1b92f 100644
--- a/source4/lib/ldb/modules/paged_results.c
+++ b/source4/lib/ldb/modules/paged_results.c
@@ -326,6 +326,11 @@ static int paged_search(struct ldb_module *module, struct ldb_request *req)
 	ac->module = module;
 	ac->req = req;
 	ac->size = paged_ctrl->size;
+	if (ac->size < 0) {
+		/* apparently some clients send more than 2^31. This
+		   violates the ldap standard, but we need to cope */
+		ac->size = 0x7FFFFFFF;
+	}
 
 	/* check if it is a continuation search the store */
 	if (paged_ctrl->cookie_len == 0) {


-- 
Samba Shared Repository


More information about the samba-cvs mailing list