[SCM] Samba Shared Repository - branch v3-5-test updated

Jeremy Allison jra at samba.org
Wed Nov 25 10:59:59 MST 2009


The branch, v3-5-test has been updated
       via  6a13107... Fix crash due to uninitialized pointer (not a problem in 3.4.x or below). Jeremy. (cherry picked from commit 947c47f2819ff30d3c69bfbeb4b1932467b36cce)
      from  bec9ed4... Remove call into reduce_name if case sensitive. This allows us to pass RAW-CHKPATH when case sensitive = yes, but isn't the correct way to do it. I'm testing a larger patch to smbd/filename.c that should fix this correctly, and will add a torture test to ensure RAW-CHKPATH is run against a case sensitive share once this is done. Jeremy. (cherry picked from commit 1ad23832cfafd46f83ac406006ff175900b81d00)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-5-test


- Log -----------------------------------------------------------------
commit 6a13107da7b1563b3bdccd66c2d7c369db7c2bb4
Author: Jeremy Allison <jra at samba.org>
Date:   Wed Nov 25 09:58:45 2009 -0800

    Fix crash due to uninitialized pointer (not a problem in 3.4.x or below).
    Jeremy.
    (cherry picked from commit 947c47f2819ff30d3c69bfbeb4b1932467b36cce)

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/open.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index 420b41c..72f6a00 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -71,7 +71,7 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 {
 	/* Check if we have rights to open. */
 	NTSTATUS status;
-	struct security_descriptor *sd;
+	struct security_descriptor *sd = NULL;
 
 	*access_granted = 0;
 
@@ -94,7 +94,6 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 			"on %s: %s\n",
 			smb_fname_str_dbg(smb_fname),
 			nt_errstr(status)));
-		TALLOC_FREE(sd);
 		return status;
 	}
 


-- 
Samba Shared Repository


More information about the samba-cvs mailing list