[SCM] Samba Shared Repository - branch v3-4-test updated

Karolin Seeger kseeger at samba.org
Mon Nov 23 01:03:54 MST 2009


The branch, v3-4-test has been updated
       via  5d6ea13... s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init
       via  210fc5a... s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init
      from  d96bc12... s3:fix endianness bug in dbwrap_change_int32_atomic() (bug #6901)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test


- Log -----------------------------------------------------------------
commit 5d6ea139d413cb05370137e4d04c4db391a06ac1
Author: Michael Adam <obnox at samba.org>
Date:   Fri Nov 20 12:44:43 2009 +0100

    s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_db_init
    
    Fix bug #6910 (idmap_ldap stumbles over idmap backend = ldap:"ldap://ldap1
    ldap://ldap2"=.
    
    When idmap backend is specified as
    idmap backend = ldap:"ldap://server1 ldap://server2"
    then currently "ldap://server1 ldap://server2" was passed to
    ldap_initialize including the quotes, leading to an ldap error.
    
    Michael

commit 210fc5a8cf384eea62cd51d398523d37723f72fb
Author: Michael Adam <obnox at samba.org>
Date:   Fri Nov 20 12:38:44 2009 +0100

    s3:idmap_ldap: trim the " chars from the location string in idmap_ldap_alloc_init
    
    When idmap alloc backend is specified as
    idmap alloc backend = ldap:"ldap://server1 ldap://server2"
    then currently "ldap://server1 ldap://server2" was passed to
    ldap_initialize including the quotes, leading to an ldap error.
    
    Michael

-----------------------------------------------------------------------

Summary of changes:
 source3/winbindd/idmap_ldap.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/winbindd/idmap_ldap.c b/source3/winbindd/idmap_ldap.c
index 3d1dd48..cdab0f0 100644
--- a/source3/winbindd/idmap_ldap.c
+++ b/source3/winbindd/idmap_ldap.c
@@ -305,6 +305,8 @@ static NTSTATUS idmap_ldap_alloc_init(const char *params)
 	}
 	CHECK_ALLOC_DONE( idmap_alloc_ldap->url );
 
+	trim_char(idmap_alloc_ldap->url, '\"', '\"');
+
 	tmp = lp_parm_const_string(-1, "idmap alloc config",
 				   "ldap_base_dn", NULL);
 	if ( ! tmp || ! *tmp) {
@@ -853,6 +855,8 @@ static NTSTATUS idmap_ldap_db_init(struct idmap_domain *dom,
 	}
 	CHECK_ALLOC_DONE(ctx->url);
 
+	trim_char(ctx->url, '\"', '\"');
+
         tmp = lp_parm_const_string(-1, config_option, "ldap_base_dn", NULL);
         if ( ! tmp || ! *tmp) {
                 tmp = lp_ldap_idmap_suffix();


-- 
Samba Shared Repository


More information about the samba-cvs mailing list