[SCM] CTDB repository - branch master updated - ctdb-1.0.103-4-g1cbf06a

[Ronnie Sahlberg]

The branch, master has been updated
       via  1cbf06a126621b3e932925cdad2ef9c009f93d4e (commit)
       via  058e21d96c3c02759833fd5ddfe7b43e6a5f5740 (commit)
      from  bf50709630df000583f2b0ef0edc177c01d60eaf (commit)

http://gitweb.samba.org/?p=sahlberg/ctdb.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit 1cbf06a126621b3e932925cdad2ef9c009f93d4e
Author: Ronnie Sahlberg <ronniesahlberg at gmail.com>
Date:   Thu Nov 5 16:07:23 2009 +1100

    dont use the pointer after it has been talloc_free()d.

commit 058e21d96c3c02759833fd5ddfe7b43e6a5f5740
Author: Ronnie Sahlberg <ronniesahlberg at gmail.com>
Date:   Thu Nov 5 15:57:46 2009 +1100

    From Rusty
    
    It's much nicer for post-mortem debugging to have a body to examine.
    
    Signed-off-by: Rusty Russell <rusty at rustcorp.com.au>

-----------------------------------------------------------------------

Summary of changes:
 config/ctdb.init      |    6 ++++++
 config/ctdb.sysconfig |    3 +++
 server/ctdb_vacuum.c  |    2 +-
 3 files changed, 10 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/config/ctdb.init b/config/ctdb.init
index df333b2..67747fd 100755
--- a/config/ctdb.init
+++ b/config/ctdb.init
@@ -144,6 +144,12 @@ start() {
 
     check_persistent_databases || return $?
 
+    if [ yes == "$CTDB_SUPPRESS_COREFILE" ]; then
+	ulimit -c 0
+    else
+	ulimit -c unlimited
+    fi
+
     case $init_style in
 	valgrind)
 	    valgrind -q --log-file=/var/log/ctdb_valgrind \
diff --git a/config/ctdb.sysconfig b/config/ctdb.sysconfig
index ca2b63f..9be69c5 100644
--- a/config/ctdb.sysconfig
+++ b/config/ctdb.sysconfig
@@ -187,6 +187,9 @@ CTDB_RECOVERY_LOCK="/some/place/on/shared/storage"
 # the default is ERR
 CTDB_DEBUGLEVEL=ERR
 
+# whether to suppress core files.  Default is no.
+# CTDB_SUPPRESS_COREFILE=yes
+
 # Write debug messages to syslog instead of logfile?
 # The default is not to use syslog.
 # CTDB_SYSLOG=no
diff --git a/server/ctdb_vacuum.c b/server/ctdb_vacuum.c
index 52f2060..da887db 100644
--- a/server/ctdb_vacuum.c
+++ b/server/ctdb_vacuum.c
@@ -646,8 +646,8 @@ static int ctdb_repack_db(struct ctdb_db_context *ctdb_db, TALLOC_CTX *mem_ctx)
 	 * decide if a repack is necessary
 	 */
 	if (size < repack_limit && vdata->delete_count < vacuum_limit) {
-		talloc_free(vdata);
 		update_tuning_db(ctdb_db, vdata, size);
+		talloc_free(vdata);
 		return 0;
 	}
 


-- 
CTDB repository