[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-1047-gb4f6bb8

Jeremy Allison jra at samba.org
Fri May 22 01:10:32 GMT 2009

On Thu, May 21, 2009 at 09:06:10PM -0400, simo wrote:
> Jeremy,
> have you really observed a case where ret == LDB_SUCCESS but res is
> NULL ?

Submitter did.

> if that's the case the fix should probably be:
> if (ret != LDB_SUCCESS || !res || (res->count != 1)) { ...

Yep, I agree and I've fixed it like that in all cases now :-).
Thanks !

> but the real bug would be in ldb_search and better fixed there.

Unfortunately I'm not as familiar with ldb_search so I'm
fixing it in the calling case. Andrew Bartlett has already
checked master to make sure this can't happen there (but
such paranoia in callers never hurts :-), but I'm guessing
he hasn't checked in the 3.2 or 3.3 code. If you want to
do that I'd be very grateful.



More information about the samba-cvs mailing list