[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1622-gd35a395

sfrench at samba.org sfrench at samba.org
Thu May 14 20:07:18 GMT 2009


The branch, master has been updated
       via  d35a3952f091f4eaad43d1a3756c24e35b34c5bd (commit)
      from  d73eab2b33b5f9d8227199bfc06f28ae3787cea3 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d35a3952f091f4eaad43d1a3756c24e35b34c5bd
Author: Steve French <smfrench at gmail.com>
Date:   Thu May 14 15:04:27 2009 -0500

    Maximum password length check too short in mount.cifs
    
        Windows allows up to 127 byte passwords, and we using a 64 byte limit
        in most places and a 16 byte limit when using the "pass=" mount option
    
        Acked-by: Jeff Layton <jlayton at redhat.com>
        Signed-off-by: Steve French <sfrench at us.ibm.com>

-----------------------------------------------------------------------

Summary of changes:
 source3/client/mount.cifs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/client/mount.cifs.c b/source3/client/mount.cifs.c
index 0c551cc..a5d99dc 100644
--- a/source3/client/mount.cifs.c
+++ b/source3/client/mount.cifs.c
@@ -77,7 +77,7 @@
 #define SAFE_FREE(x) do { if ((x) != NULL) {free(x); x=NULL;} } while(0)
 #endif
 
-#define MOUNT_PASSWD_SIZE 64
+#define MOUNT_PASSWD_SIZE 128
 #define DOMAIN_SIZE 64
 
 /* currently maximum length of IPv6 address string */
@@ -473,7 +473,7 @@ static int parse_options(char ** optionsp, int * filesys_flags)
 					printf("\npassword specified twice, ignoring second\n");
 				} else
 					got_password = 1;
-			} else if (strnlen(value, 17) < 17) {
+			} else if (strnlen(value, MOUNT_PASSWD_SIZE) < MOUNT_PASSWD_SIZE) {
 				if(got_password)
 					printf("\nmount.cifs warning - password specified twice\n");
 				got_password = 1;


-- 
Samba Shared Repository


More information about the samba-cvs mailing list