[SCM] Samba Shared Repository - branch v3-4-test updated - release-4-0-0alpha7-918-g32eaef7

[Jeremy Allison]

The branch, v3-4-test has been updated
       via  32eaef7d2f2e9be171f835b8f440b7c78ee22bd8 (commit)
      from  369c52cc8c3042dab5b60c25c03218a761ffd3ef (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-4-test


- Log -----------------------------------------------------------------
commit 32eaef7d2f2e9be171f835b8f440b7c78ee22bd8
Author: Jeremy Allison <jra at samba.org>
Date:   Fri May 8 10:11:38 2009 -0700

    Expand the comment explaining why user_in_group_sid is
    not reliable for winbindd users from foreign domains.
    Jeremy.

-----------------------------------------------------------------------

Summary of changes:
 source3/smbd/posix_acls.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c
index abfb00c..8d172e1 100644
--- a/source3/smbd/posix_acls.c
+++ b/source3/smbd/posix_acls.c
@@ -1297,7 +1297,12 @@ static bool uid_entry_in_group( canon_ace *uid_ace, canon_ace *group_ace )
 		return False;
 	}
 
-	/* notice that this is not reliable for users exported by winbindd! */
+	/*
+	 * user_in_group_sid() uses create_token_from_username()
+	 * which creates an artificial NT token given just a username,
+	 * so this is not reliable for users from foreign domains
+	 * exported by winbindd!
+	 */
 	return user_in_group_sid(u_name, &group_ace->trustee);
 }
 


-- 
Samba Shared Repository