[SCM] Samba Shared Repository - branch master updated - release-4-0-0alpha7-1504-gd7b32b5

Günther Deschner gd at samba.org
Thu May 7 23:25:07 GMT 2009


The branch, master has been updated
       via  d7b32b51f840d34e0ecb62dd8b7df862974d6271 (commit)
      from  c469ec5c10b48548e1fae51511bd55fb437a0a89 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master


- Log -----------------------------------------------------------------
commit d7b32b51f840d34e0ecb62dd8b7df862974d6271
Author: Günther Deschner <gd at samba.org>
Date:   Fri May 8 01:23:54 2009 +0200

    s3-samr: Fix potential memory leak in _samr_ChangePasswordUser().
    
    Guenther

-----------------------------------------------------------------------

Summary of changes:
 source3/rpc_server/srv_samr_nt.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


Changeset truncated at 500 lines:

diff --git a/source3/rpc_server/srv_samr_nt.c b/source3/rpc_server/srv_samr_nt.c
index 862917b..389a6d5 100644
--- a/source3/rpc_server/srv_samr_nt.c
+++ b/source3/rpc_server/srv_samr_nt.c
@@ -1813,7 +1813,8 @@ NTSTATUS _samr_ChangePasswordUser(pipes_struct *p,
 		nt_pass = pdb_get_nt_passwd(pwd);
 
 		if (!lm_pass || !nt_pass) {
-			return NT_STATUS_WRONG_PASSWORD;
+			status = NT_STATUS_WRONG_PASSWORD;
+			goto out;
 		}
 
 		memcpy(&lm_pwd.hash, lm_pass, sizeof(lm_pwd.hash));


-- 
Samba Shared Repository


More information about the samba-cvs mailing list